Register decimals as string

Author: ulgens

graphene_django/filter/tests/test_fields.py

@@ -388,7 +388,7 @@ class Meta:
     field = DjangoFilterConnectionField(ArticleNode, filterset_class=ArticleIdFilter)
     max_time = field.args["max_time"]
     assert isinstance(max_time, Argument)
-    assert max_time.type == Float
+    assert max_time.type == String
     assert max_time.description == "The maximum time"
 
 

graphene_django/forms/converter.py

@@ -20,6 +20,7 @@ def convert_form_field(field):
 
 @convert_form_field.register(forms.fields.BaseTemporalField)
 @convert_form_field.register(forms.CharField)
+@convert_form_field.register(forms.DecimalField)
 @convert_form_field.register(forms.EmailField)
 @convert_form_field.register(forms.SlugField)
 @convert_form_field.register(forms.URLField)
@@ -51,7 +52,6 @@ def convert_form_field_to_nullboolean(field):
     return Boolean(description=field.help_text)
 
 
-@convert_form_field.register(forms.DecimalField)
 @convert_form_field.register(forms.FloatField)
 def convert_form_field_to_float(field):
     return Float(description=field.help_text, required=field.required)

graphene_django/forms/tests/test_converter.py

@@ -50,6 +50,10 @@ def test_should_char_convert_string():
     assert_conversion(forms.CharField, String)
 
 
+def test_should_decimal_convert_string():
+    assert_conversion(forms.DecimalField, String)
+
+
 def test_should_email_convert_string():
     assert_conversion(forms.EmailField, String)
 
@@ -97,10 +101,6 @@ def test_should_float_convert_float():
     assert_conversion(forms.FloatField, Float)
 
 
-def test_should_decimal_convert_float():
-    assert_conversion(forms.DecimalField, Float)
-
-
 def test_should_multiple_choice_convert_connectionorlist():
     field = forms.ModelMultipleChoiceField(queryset=None)
     graphene_type = convert_form_field(field)