Skip to content

Commit 88c9c80

Browse files
committed
Re-enable tests that depend on SourceLocation
1 parent e3805ef commit 88c9c80

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

graphene_django/tests/test_views.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,6 @@ def test_allows_get_with_operation_name(client):
9292
}
9393

9494

95-
@pytest.mark.xfail(
96-
reason="SourceLocation serialization problem: https://github.com/graphql-python/graphql-core-next/issues/61"
97-
)
9895
def test_reports_validation_errors(client):
9996
response = client.get(url_string(query="{ test, unknownOne, unknownTwo }"))
10097

@@ -449,9 +446,6 @@ def test_supports_pretty_printing_by_request(client):
449446
)
450447

451448

452-
@pytest.mark.xfail(
453-
reason="SourceLocation serialization problem: https://github.com/graphql-python/graphql-core-next/issues/61"
454-
)
455449
def test_handles_field_errors_caught_by_graphql(client):
456450
response = client.get(url_string(query="{thrower}"))
457451
assert response.status_code == 200
@@ -467,18 +461,15 @@ def test_handles_field_errors_caught_by_graphql(client):
467461
}
468462

469463

470-
@pytest.mark.xfail(
471-
reason="SourceLocation serialization problem: https://github.com/graphql-python/graphql-core-next/issues/61"
472-
)
473464
def test_handles_syntax_errors_caught_by_graphql(client):
474465
response = client.get(url_string(query="syntaxerror"))
475466
assert response.status_code == 400
476467
assert response_json(response) == {
477468
"errors": [
478469
{
479470
"locations": [{"column": 1, "line": 1}],
480-
"message": "Syntax Error GraphQL (1:1) "
481-
'Unexpected Name "syntaxerror"\n\n1: syntaxerror\n ^\n',
471+
"message": "Syntax Error: Unexpected Name 'syntaxerror'",
472+
"path": None,
482473
}
483474
]
484475
}

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
install_requires=[
5656
"six>=1.10.0",
5757
"graphene>=3.0.dev,<4",
58-
"graphql-core>=3.0.0b0,<4",
58+
"graphql-core>=3.0.0b1,<4",
5959
"Django>=1.11",
6060
"promise>=2.1",
6161
],

0 commit comments

Comments
 (0)