fix: clear cache for composeWithMongoose() if it is called several times for the same model, then need to generate new types

Author: nodkz

src/__tests__/composeWithMongoose-test.js

@@ -153,7 +153,7 @@ describe('composeWithMongoose ->', () => {
       it('should be called if opts.resolvers not exists or has value', () => {
         const tc = composeWithMongoose(UserModel);
         expect(Array.from(tc.getResolvers().keys())).not.toHaveLength(0);
-        const tc2 = composeWithMongoose(UserModel, { resolvers: {} });
+        const tc2 = composeWithMongoose(UserModel, { resolvers: {}, name: 'User2' });
         expect(Array.from(tc2.getResolvers().keys())).not.toHaveLength(0);
       });
 

src/__tests__/integration-test.js

@@ -127,6 +127,7 @@ describe('integration tests', () => {
     let schema;
     let UserTC;
     beforeAll(async () => {
+      schemaComposer.clear();
       UserTC = composeWithMongoose(UserModel);
       UserTC.addFields({
         rawData: {

src/composeWithMongoose.js

@@ -124,6 +124,18 @@ export function composeWithMongoose<TSource, TContext>(
 
   const sc = opts.schemaComposer || globalSchemaComposer;
   sc.add(MongoID);
+
+  if (sc.has(name)) {
+    throw new Error(
+      `You try to generate GraphQL Type with name ${name} from mongoose model but this type already exists in SchemaComposer. Please choose another type name "composeWithMongoose(model, { name: 'NewTypeName' })", or reuse existed type "schemaComposer.getOTC('TypeName')", or remove type from SchemaComposer before calling composeWithMongoose method "schemaComposer.delete('TypeName')".`
+    );
+  }
+  if (sc.has(m.schema)) {
+    // looks like you want to generate new TypeComposer from model
+    // so remove cached model (which is used for cross-reference types)
+    sc.delete(m.schema);
+  }
+
   const tc = convertModelToGraphQL((m: any), name, sc);
 
   if (opts.description) {

src/discriminators/__tests__/DiscriminatorTypeComposer-test.js

@@ -16,6 +16,7 @@ const { CharacterModel, PersonModel, DroidModel } = getCharacterModels('type');
 
 describe('DiscriminatorTypeComposer', () => {
   it('should have as interface DInterface', () => {
+    schemaComposer.clear();
     const baseDTC = composeWithMongooseDiscriminators(CharacterModel);
     expect(baseDTC.hasInterface(baseDTC.getDInterface())).toBeTruthy();
   });
@@ -483,6 +484,7 @@ describe('DiscriminatorTypeComposer', () => {
     let characterDTC;
 
     beforeEach(() => {
+      schemaComposer.clear();
       characterDTC = composeWithMongooseDiscriminators(CharacterModel);
     });
 

src/discriminators/__tests__/prepareChildResolvers-test.js

@@ -15,6 +15,7 @@ describe('prepareChildResolvers()', () => {
     let PersonTC: ObjectTypeComposer<any, any>;
 
     beforeAll(() => {
+      schemaComposer.clear();
       PersonTC = composeWithMongooseDiscriminators(CharacterModel).discriminator(PersonModel);
     });
 
@@ -54,6 +55,7 @@ describe('prepareChildResolvers()', () => {
     const interestArgs = ['filter', 'record', 'records'];
 
     beforeAll(() => {
+      schemaComposer.clear();
       const PersonTC = composeWithMongooseDiscriminators(CharacterModel).discriminator(PersonModel);
 
       const resolvers = PersonTC.getResolvers();

src/fieldsConverter.js

@@ -130,12 +130,7 @@ export function convertModelToGraphQL<TSource, TContext>(
   }
 
   // if model already has generated ObjectTypeComposer early, then return it
-  if (sc.has(model.schema) && sc.has(typeName)) {
-    if (sc.get(model.schema) !== sc.get(typeName)) {
-      throw new Error(
-        `You try to generate GrpahQL Type with name ${typeName} from mongoose model but this type already exists in SchemaComposer. Please choose another type name or remove existed type from schemaComposer.`
-      );
-    }
+  if (sc.has(model.schema)) {
     return sc.getOTC(model.schema);
   }