Skip to content

Commit defda5e

Browse files
committed
feat: improve return types for createMany, findByIds, findMany resolvers ([Type] -> [Type!])
1 parent 6f20e1d commit defda5e

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

src/resolvers/__tests__/createMany-test.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,15 +194,13 @@ describe('createMany() ->', () => {
194194
});
195195

196196
it('should have recordIds field, NonNull List', () => {
197-
const outputType: any = createMany(UserModel, UserTC).getType();
198-
const recordIdField = schemaComposer.createObjectTC(outputType).getFieldConfig('recordIds');
199-
expect(recordIdField.type).toEqual(new GraphQLNonNull(GraphQLList(GraphQLMongoID)));
197+
const resolver = createMany(UserModel, UserTC);
198+
expect(resolver.getOTC().getFieldTypeName('recordIds')).toEqual('[MongoID!]!');
200199
});
201200

202201
it('should have records field, NonNull List', () => {
203-
const outputType: any = createMany(UserModel, UserTC).getType();
204-
const recordField = schemaComposer.createObjectTC(outputType).getFieldConfig('records');
205-
expect(recordField.type).toEqual(new GraphQLNonNull(GraphQLList(UserTC.getType())));
202+
const resolver = createMany(UserModel, UserTC);
203+
expect(resolver.getOTC().getFieldTypeName('records')).toEqual('[User!]!');
206204
});
207205

208206
it('should have createCount field, Int', () => {

src/resolvers/createMany.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ export default function createMany<TSource: MongooseDocument, TContext>(
5151
const outputType = tc.schemaComposer.getOrCreateOTC(outputTypeName, (t) => {
5252
t.addFields({
5353
recordIds: {
54-
type: '[MongoID]!',
54+
type: '[MongoID!]!',
5555
description: 'Created document ID',
5656
},
5757
records: {
58-
type: tc.getTypePlural().getTypeNonNull(),
58+
type: tc.getTypeNonNull().getTypePlural().getTypeNonNull(),
5959
description: 'Created documents',
6060
},
6161
createCount: {

src/resolvers/findByIds.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export default function findByIds<TSource: MongooseDocument, TContext>(
2828
}
2929

3030
return tc.schemaComposer.createResolver({
31-
type: [tc],
31+
type: tc.getTypeNonNull().getTypePlural(),
3232
name: 'findByIds',
3333
kind: 'query',
3434
args: {

src/resolvers/findMany.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export default function findMany<TSource: MongooseDocument, TContext>(
3131
}
3232

3333
return tc.schemaComposer.createResolver({
34-
type: [tc],
34+
type: tc.getTypeNonNull().getTypePlural(),
3535
name: 'findMany',
3636
kind: 'query',
3737
args: {

0 commit comments

Comments
 (0)