Skip to content

Commit 9f62623

Browse files
committed
fix: resolver updateById now have all optional fields in record arg
1 parent 5e49fde commit 9f62623

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

src/resolvers/__tests__/updateById-test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,5 +235,11 @@ describe('updateById() ->', () => {
235235
const outputType = updateById(UserModel, UserTC).getType();
236236
expect(outputType).toBe(existedType.getType());
237237
});
238+
239+
it('should have all fields optional in record', () => {
240+
const resolver = updateById(UserModel, UserTC);
241+
expect(resolver.getArgITC('record').getFieldTypeName('name')).toBe('String');
242+
expect(resolver.getArgITC('record').getFieldTypeName('age')).toBe('Float');
243+
});
238244
});
239245
});

src/resolvers/__tests__/updateMany-test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,10 @@ describe('updateMany() ->', () => {
156156
const resolver = updateMany(UserModel, UserTC);
157157
expect(resolver.getArgITC('filter').getFieldTypeName('name')).toBe('String');
158158
expect(resolver.getArgITC('filter').getFieldTypeName('age')).toBe('Float');
159+
});
160+
161+
it('should have all fields optional in record', () => {
162+
const resolver = updateMany(UserModel, UserTC);
159163
expect(resolver.getArgITC('record').getFieldTypeName('name')).toBe('String');
160164
expect(resolver.getArgITC('record').getFieldTypeName('age')).toBe('Float');
161165
});

src/resolvers/updateById.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ export default function updateById<TSource: MongooseDocument, TContext>(
5454
recordTypeName: `UpdateById${tc.getTypeName()}Input`,
5555
requiredFields: ['_id'],
5656
isRequired: true,
57+
allFieldsNullable: true,
5758
...(opts && opts.record),
5859
}),
5960
},

0 commit comments

Comments
 (0)