fix(FieldConverter): do not strip _id from embedded documents

Author: Mark Cola

src/__tests__/fieldConverter-test.js

@@ -170,7 +170,7 @@ describe('fieldConverter', () => {
       const embeddedFields = embeddedType._typeConfig.fields();
       expect(embeddedFields.email).to.be.ok;
       expect(embeddedFields.locationId).to.be.ok;
-      expect(embeddedFields._id).to.be.undefined;
+      expect(embeddedFields._id).to.be.ok;
     });
 
     it('should return null if subdocument is empty', async () => {
@@ -262,8 +262,8 @@ describe('fieldConverter', () => {
       expect(languagesType.ofType.name).to.equal('Language');
     });
 
-    it('should skip pseudo mongoose _id field in document', () => {
-      expect(languagesFields._id).to.be.undefined;
+    it('should include pseudo mongoose _id field in document', () => {
+      expect(languagesFields._id).to.be.ok;
     });
   });
 

src/fieldsConverter.js

@@ -248,17 +248,6 @@ export function deriveComplexType(field: MongooseFieldT): ComplexTypesT {
   return ComplexTypes.SCALAR;
 }
 
-function removePseudoIdField(typeComposer: TypeComposer): void {
-  // remove pseudo object id mongoose field
-  const gqFields = typeComposer.getFields();
-  const pseudoFieldNames = ['_id'];
-  pseudoFieldNames.forEach((name) => {
-    if (gqFields[name] && gqFields[name].type === GraphQLMongoID) {
-      typeComposer.removeField(name);
-    }
-  });
-}
-
 export function scalarToGraphQL(field: MongooseFieldT): GraphQLOutputType {
   const typeName = _getFieldType(field);
 
@@ -304,12 +293,10 @@ export function embeddedToGraphQL(
 
   const typeName = `${prefix}${capitalize(fieldName)}`;
   const typeComposer = convertSchemaToGraphQL(field.schema, typeName);
-  removePseudoIdField(typeComposer);
 
   return typeComposer.getType();
 }
 
-
 export function enumToGraphQL(
   field: MongooseFieldT,
   prefix: string = ''
@@ -349,7 +336,6 @@ export function documentArrayToGraphQL(
   const typeName = `${prefix}${capitalize(_getFieldName(field))}`;
 
   const typeComposer = convertModelToGraphQL(field, typeName);
-  removePseudoIdField(typeComposer);
 
   return new GraphQLList(typeComposer.getType());
 }