fix: table creation in example #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@denyshuzovskyi can you please explain the needs for these changes? Are they intended to be in the open source code or were they intended for a private fork? |
Contributor
Author
|
@pablochacin The examples/example.js script contains an inconsistency between the table creation and the data insertion logic. Specifically, it creates a table named keyvalues, but attempts to insert records into a different, non-existent table named roster. As a result, running the example as-is results in an error |
pablochacin
approved these changes
Apr 25, 2025
Contributor
There was a problem hiding this comment.
@denyshuzovskyi, thanks for the catch and the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.