Skip to content

Conversation

@DylanGuedes
Copy link
Contributor

@DylanGuedes DylanGuedes commented Dec 3, 2024

What this PR does / why we need it:
Add a tls_config block to the analytics client. It can be especially useful in scenarios where the client goes under a knwon proxy.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@DylanGuedes DylanGuedes requested a review from a team as a code owner December 3, 2024 10:38
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 3, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 9, 2024
@DylanGuedes DylanGuedes merged commit 2c5eabd into main Dec 10, 2024
59 checks passed
@DylanGuedes DylanGuedes deleted the add-tls-config-to-analytics branch December 10, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants