Fix handling of Watch and Status objects in GenericJSONDecoder #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What: This commit fixes the handling of objects in the decoder by properly dispatching watch & status types. Why: Those types were not handled properly before, causing WatchList to sometimes fail, if watch encountered retryable errors. Signed-off-by: Igor Suleymanov <[email protected]>
radiohead
requested review from
IfSentient,
MissingRoberto and
spinillos
and removed request for
MissingRoberto
IfSentient
reviewed
Oct 28, 2025
k8s/negotiator.go
Outdated
|
|
||
| switch { | ||
| case chk.Type != "": // Watch | ||
| obj, ok := into.(*metav1.WatchEvent) |
There was a problem hiding this comment.
If into is nil here, should we instead set into into a *metav1.WatchEvent? In the CodecDecoder we have the into type checks if into is non-nil, and then fallback handling for a nil into (checking defaults, then trying the check unmarshal and examining that).
Signed-off-by: Igor Suleymanov <[email protected]>
radiohead
force-pushed
the
fix/watch-status-errors
branch
from
0f9c173 to
18aca36
Compare
IfSentient
requested changes
Oct 29, 2025
k8s/wrappers.go
Outdated
| return codec.Read(bytes.NewReader(o.object), into) | ||
| } | ||
|
|
||
| // UntypedListObjectWrapper wraps a list of UntypedObjectWrappers, and implements runtime.Object |
There was a problem hiding this comment.
This godoc seems incorrect, given that items is a json.RawMessage. Does UntypedListObjectWrapper need to allow for access to the items by the reflector, or does it get iterated over by internal machinery to get those? IIRC for the informer to process a list, it needs to have an exported Items field which is a slice of objects.
Signed-off-by: Igor Suleymanov <[email protected]>
IfSentient
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This commit fixes the handling of objects in the decoder by properly dispatching watch & status types.
Why
Those types were not handled properly before, causing WatchList to sometimes fail, if watch encountered retryable errors.