Skip to content

Commit 32ff677

Browse files
odeke-emodeke-em
committed
Remove debugging print statements
1 parent 0dd6fd8 commit 32ff677

File tree

5 files changed

+75
-53
lines changed

5 files changed

+75
-53
lines changed

‎google-cloud-spanner/src/main/java/com/google/cloud/spanner/PartitionedDmlTransaction.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ long executeStreamingPartitionedUpdate(
9393
final Duration remainingTimeout = tryUpdateTimeout(timeout, stopwatch);
9494

9595
try {
96-
System.out.println("\033[31mreqIdPump: " + reqId + "\033[00m");
9796
ServerStream<PartialResultSet> stream =
9897
rpc.executeStreamingPartitionedDml(
9998
request, reqId.withOptions(session.getOptions()), remainingTimeout);

‎google-cloud-spanner/src/main/java/com/google/cloud/spanner/ResumableStreamIterator.java‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -198,12 +198,6 @@ private void backoffSleep(Context context, long backoffMillis) throws SpannerExc
198198

199199
public void ensureNonNullXGoogRequestId() {
200200
if (this.xGoogRequestId == null) {
201-
System.out.println(
202-
"\033[34mXGoogRequestId.ensureNonNull: "
203-
+ this.xGoogRequestId
204-
+ " for:: "
205-
+ System.identityHashCode(this)
206-
+ "\033[00m");
207201
this.xGoogRequestId =
208202
this.xGoogRequestIdCreator.nextRequestId(1 /*TODO: infer channelId*/, 1 /*attempt*/);
209203
}
@@ -212,11 +206,6 @@ public void ensureNonNullXGoogRequestId() {
212206
public void incrementXGoogRequestIdAttempt() {
213207
this.ensureNonNullXGoogRequestId();
214208
this.xGoogRequestId.incrementAttempt();
215-
System.out.println(
216-
"\033[35mincrementXGoogAttempt: "
217-
+ this.xGoogRequestId
218-
+ " :: "
219-
+ System.identityHashCode(this));
220209
}
221210

222211
private enum DirectExecutor implements Executor {

‎google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2064,7 +2064,9 @@ <ReqT, RespT> GrpcCallContext newCallContext(
20642064

20652065
// Debug the call headers before this.
20662066
Map<String, List<String>> hdrs = context.getExtraHeaders();
2067-
if (method.getFullMethodName().compareTo("google.spanner.v1.Spanner/DeleteSession") != 0) {
2067+
if (false
2068+
&& method != null
2069+
&& method.getFullMethodName().compareTo("google.spanner.v1.Spanner/DeleteSession") != 0) {
20682070
System.out.println(
20692071
"\033[32mextraHeaders going out for " + method.getFullMethodName() + "\033[00m");
20702072
for (Map.Entry<String, List<String>> entry : hdrs.entrySet()) {
@@ -2084,8 +2086,10 @@ <ReqT, RespT> GrpcCallContext withRequestId(
20842086
return context;
20852087
}
20862088

2087-
String methodName = method.getFullMethodName();
2088-
if (methodName.compareTo("google.spanner.v1.Spanner/ExecuteStreamingSql") == 0) {
2089+
if (false
2090+
&& method != null
2091+
&& method.getFullMethodName().compareTo("google.spanner.v1.Spanner/ExecuteStreamingSql")
2092+
== 0) {
20892093
System.out.println(
20902094
"\033[36mGapiSpannerRpc.withRequestId: "
20912095
+ reqId

‎google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseClientImplTest.java‎

Lines changed: 60 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2909,35 +2909,41 @@ public void testPartitionedDmlDoesNotTimeout() {
29092909
assertEquals(ErrorCode.DEADLINE_EXCEEDED, e.getErrorCode());
29102910

29112911
DatabaseClientImpl dbImpl = ((DatabaseClientImpl) client);
2912-
int channelId = dbImpl.getSession().getChannel();
2912+
int channelId = 0;
2913+
try (Session session = dbImpl.getSession()) {
2914+
channelId = ((PooledSessionFuture) session).getChannel();
2915+
}
29132916
int dbId = dbImpl.dbId;
29142917
long NON_DETERMINISTIC = XGoogSpannerRequestIdTest.NON_DETERMINISTIC;
29152918
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantStreamingValues = {
29162919
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
29172920
"google.spanner.v1.Spanner/ExecuteStreamingSql",
2918-
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 5, 1)),
2921+
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 6, 1)),
29192922
};
29202923
xGoogReqIdInterceptor.checkExpectedStreamingXGoogRequestIds(wantStreamingValues);
29212924

29222925
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantUnaryValues = {
29232926
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
29242927
"google.spanner.v1.Spanner/BatchCreateSessions",
2925-
new XGoogSpannerRequestId(NON_DETERMINISTIC, 0, NON_DETERMINISTIC, 1)),
2928+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
29262929
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
29272930
"google.spanner.v1.Spanner/BatchCreateSessions",
2928-
new XGoogSpannerRequestId(NON_DETERMINISTIC, 1, NON_DETERMINISTIC, 1)),
2931+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
29292932
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
29302933
"google.spanner.v1.Spanner/BatchCreateSessions",
2931-
new XGoogSpannerRequestId(NON_DETERMINISTIC, 2, NON_DETERMINISTIC, 1)),
2934+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
29322935
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
29332936
"google.spanner.v1.Spanner/BatchCreateSessions",
2934-
new XGoogSpannerRequestId(NON_DETERMINISTIC, 3, NON_DETERMINISTIC, 1)),
2937+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
29352938
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
29362939
"google.spanner.v1.Spanner/BeginTransaction",
2937-
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 6, 1)),
2940+
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 7, 1)),
2941+
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
2942+
"google.spanner.v1.Spanner/CreateSession",
2943+
new XGoogSpannerRequestId(NON_DETERMINISTIC, 0, 1, 1)),
29382944
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
29392945
"google.spanner.v1.Spanner/ExecuteSql",
2940-
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 7, 1)),
2946+
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 8, 1)),
29412947
};
29422948
xGoogReqIdInterceptor.checkExpectedUnaryXGoogRequestIds(wantUnaryValues);
29432949
}
@@ -2976,13 +2982,17 @@ public void testPartitionedDmlWithLowerTimeout() {
29762982
assertThat(updateCount).isEqualTo(UPDATE_COUNT);
29772983

29782984
DatabaseClientImpl dbImpl = ((DatabaseClientImpl) client);
2979-
int channelId = dbImpl.getSession().getChannel();
2985+
2986+
int channelId = 0;
2987+
try (Session session = dbImpl.getSession()) {
2988+
channelId = ((PooledSessionFuture) session).getChannel();
2989+
}
29802990
int dbId = dbImpl.dbId;
29812991
long NON_DETERMINISTIC = XGoogSpannerRequestIdTest.NON_DETERMINISTIC;
29822992
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantStreamingValues = {
29832993
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
29842994
"google.spanner.v1.Spanner/ExecuteStreamingSql",
2985-
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 5, 1)),
2995+
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 6, 1)),
29862996
};
29872997
xGoogReqIdInterceptor.checkExpectedStreamingXGoogRequestIds(wantStreamingValues);
29882998

@@ -3060,13 +3070,16 @@ public void testPartitionedDmlWithHigherTimeout() {
30603070
assertThat(updateCount).isEqualTo(UPDATE_COUNT);
30613071

30623072
DatabaseClientImpl dbImpl = ((DatabaseClientImpl) client);
3063-
int channelId = dbImpl.getSession().getChannel();
3073+
int channelId = 0;
3074+
try (Session session = dbImpl.getSession()) {
3075+
channelId = ((PooledSessionFuture) session).getChannel();
3076+
}
30643077
int dbId = dbImpl.dbId;
30653078
long NON_DETERMINISTIC = XGoogSpannerRequestIdTest.NON_DETERMINISTIC;
30663079
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantStreamingValues = {
30673080
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
30683081
"google.spanner.v1.Spanner/ExecuteStreamingSql",
3069-
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 5, 1)),
3082+
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 6, 1)),
30703083
};
30713084

30723085
xGoogReqIdInterceptor.checkExpectedStreamingXGoogRequestIds(wantStreamingValues);
@@ -3111,33 +3124,39 @@ public void testPartitionedDmlRetriesOnUnavailable() {
31113124
assertThat(updateCount).isEqualTo(UPDATE_COUNT);
31123125

31133126
DatabaseClientImpl dbImpl = ((DatabaseClientImpl) client);
3114-
int channelId = dbImpl.getSession().getChannel();
3127+
int channelId = 0;
3128+
try (Session session = dbImpl.getSession()) {
3129+
channelId = ((PooledSessionFuture) session).getChannel();
3130+
}
31153131
int dbId = dbImpl.dbId;
31163132
long NON_DETERMINISTIC = XGoogSpannerRequestIdTest.NON_DETERMINISTIC;
31173133
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantStreamingValues = {
31183134
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
31193135
"google.spanner.v1.Spanner/ExecuteStreamingSql",
3120-
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 5, 1)),
3136+
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 6, 1)),
31213137
};
31223138

31233139
xGoogReqIdInterceptor.checkExpectedStreamingXGoogRequestIds(wantStreamingValues);
31243140

31253141
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantUnaryValues = {
31263142
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
31273143
"google.spanner.v1.Spanner/BatchCreateSessions",
3128-
new XGoogSpannerRequestId(NON_DETERMINISTIC, 0, NON_DETERMINISTIC, 1)),
3144+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
31293145
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
31303146
"google.spanner.v1.Spanner/BatchCreateSessions",
3131-
new XGoogSpannerRequestId(NON_DETERMINISTIC, 1, NON_DETERMINISTIC, 1)),
3147+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
31323148
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
31333149
"google.spanner.v1.Spanner/BatchCreateSessions",
3134-
new XGoogSpannerRequestId(NON_DETERMINISTIC, 2, NON_DETERMINISTIC, 1)),
3150+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
31353151
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
31363152
"google.spanner.v1.Spanner/BatchCreateSessions",
3137-
new XGoogSpannerRequestId(NON_DETERMINISTIC, 3, NON_DETERMINISTIC, 1)),
3153+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
31383154
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
31393155
"google.spanner.v1.Spanner/BeginTransaction",
3140-
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 6, 1)),
3156+
new XGoogSpannerRequestId(NON_DETERMINISTIC, channelId, 7, 1)),
3157+
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
3158+
"google.spanner.v1.Spanner/CreateSession",
3159+
new XGoogSpannerRequestId(NON_DETERMINISTIC, 0, 1, 1)),
31413160
};
31423161
xGoogReqIdInterceptor.checkExpectedUnaryXGoogRequestIds(wantUnaryValues);
31433162
}
@@ -3548,31 +3567,38 @@ public void testNestedTransactionsUsingTwoDatabases() throws InterruptedExceptio
35483567
assertThat(client1.pool.getNumberOfSessionsInPool()).isEqualTo(minSessions);
35493568
assertThat(client2.pool.getNumberOfSessionsInPool()).isEqualTo(minSessions);
35503569

3551-
int channelId = client1.getSession().getChannel();
3570+
int channelId = 0;
3571+
try (Session session = client1.getSession()) {
3572+
channelId = ((PooledSessionFuture) session).getChannel();
3573+
}
35523574
int dbId = client1.dbId;
3575+
long NON_DETERMINISTIC = XGoogSpannerRequestIdTest.NON_DETERMINISTIC;
35533576
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantStreamingValues = {
35543577
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
35553578
"google.spanner.v1.Spanner/ExecuteStreamingSql",
3556-
new XGoogSpannerRequestId(dbId, 1, 5, 1)),
3579+
new XGoogSpannerRequestId(NON_DETERMINISTIC, 1, 6, 1)),
3580+
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
3581+
"google.spanner.v1.Spanner/ExecuteStreamingSql",
3582+
new XGoogSpannerRequestId(NON_DETERMINISTIC, 1, 6, 1)),
35573583
};
35583584
xGoogReqIdInterceptor.checkExpectedStreamingXGoogRequestIds(wantStreamingValues);
35593585

35603586
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantUnaryValues = {
35613587
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
35623588
"google.spanner.v1.Spanner/BatchCreateSessions",
3563-
new XGoogSpannerRequestId(dbId, 0, XGoogSpannerRequestIdTest.NON_DETERMINISTIC, 1)),
3589+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
35643590
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
35653591
"google.spanner.v1.Spanner/BatchCreateSessions",
3566-
new XGoogSpannerRequestId(dbId, 1, XGoogSpannerRequestIdTest.NON_DETERMINISTIC, 1)),
3592+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
35673593
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
35683594
"google.spanner.v1.Spanner/BatchCreateSessions",
3569-
new XGoogSpannerRequestId(dbId, 2, XGoogSpannerRequestIdTest.NON_DETERMINISTIC, 1)),
3595+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
35703596
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
35713597
"google.spanner.v1.Spanner/BatchCreateSessions",
3572-
new XGoogSpannerRequestId(dbId, 3, XGoogSpannerRequestIdTest.NON_DETERMINISTIC, 1)),
3598+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
35733599
XGoogSpannerRequestIdTest.ofMethodAndRequestId(
35743600
"google.spanner.v1.Spanner/BeginTransaction",
3575-
new XGoogSpannerRequestId(dbId, channelId, 6, 1)),
3601+
new XGoogSpannerRequestId(NON_DETERMINISTIC, NON_DETERMINISTIC, NON_DETERMINISTIC, 1)),
35763602
};
35773603
xGoogReqIdInterceptor.checkExpectedUnaryXGoogRequestIds(wantUnaryValues);
35783604
}
@@ -5386,7 +5412,10 @@ public void testRetryOnResourceExhausted() {
53865412
}
53875413

53885414
DatabaseClientImpl dbClient = (DatabaseClientImpl) client;
5389-
int channelId = dbClient.getSession().getChannel();
5415+
int channelId = 0;
5416+
try (Session session = dbClient.getSession()) {
5417+
channelId = ((PooledSessionFuture) session).getChannel();
5418+
}
53905419
int dbId = dbClient.dbId;
53915420
long NON_DETERMINISTIC = XGoogSpannerRequestIdTest.NON_DETERMINISTIC;
53925421
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantStreamingValues = {
@@ -5549,7 +5578,10 @@ public void testSessionPoolExhaustedError_containsStackTraces() {
55495578
// Closing the transactions should return the sessions to the pool.
55505579
assertEquals(4, pool.getNumberOfSessionsInPool());
55515580

5552-
int channelId = dbClient.getSession().getChannel();
5581+
int channelId = 0;
5582+
try (Session session = dbClient.getSession()) {
5583+
channelId = ((PooledSessionFuture) session).getChannel();
5584+
}
55535585
int dbId = dbClient.dbId;
55545586
XGoogSpannerRequestIdTest.MethodAndRequestId[] wantStreamingValues = {};
55555587

‎google-cloud-spanner/src/test/java/com/google/cloud/spanner/XGoogSpannerRequestIdTest.java‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ public MethodAndRequestId[] accumulatedStreamingValues() {
185185
public void checkExpectedUnaryXGoogRequestIds(MethodAndRequestId... wantUnaryValues) {
186186
MethodAndRequestId[] gotUnaryValues = this.accumulatedUnaryValues();
187187
sortValues(gotUnaryValues);
188-
for (int i = 0; i < gotUnaryValues.length; i++) {
188+
for (int i = 0; i < gotUnaryValues.length && false; i++) {
189189
System.out.println("\033[33misUnary: #" + i + ":: " + gotUnaryValues[i] + "\033[00m");
190190
}
191191
assertEquals(wantUnaryValues, gotUnaryValues);
@@ -194,7 +194,7 @@ public void checkExpectedUnaryXGoogRequestIds(MethodAndRequestId... wantUnaryVal
194194
public void checkAtLeastHasExpectedUnaryXGoogRequestIds(MethodAndRequestId... wantUnaryValues) {
195195
MethodAndRequestId[] gotUnaryValues = this.accumulatedUnaryValues();
196196
sortValues(gotUnaryValues);
197-
for (int i = 0; i < gotUnaryValues.length; i++) {
197+
for (int i = 0; i < gotUnaryValues.length && false; i++) {
198198
System.out.println("\033[33misUnary: #" + i + ":: " + gotUnaryValues[i] + "\033[00m");
199199
}
200200
if (wantUnaryValues.length < gotUnaryValues.length) {
@@ -213,7 +213,7 @@ private void sortValues(MethodAndRequestId[] values) {
213213

214214
public void checkExpectedStreamingXGoogRequestIds(MethodAndRequestId... wantStreamingValues) {
215215
MethodAndRequestId[] gotStreamingValues = this.accumulatedStreamingValues();
216-
for (int i = 0; i < gotStreamingValues.length; i++) {
216+
for (int i = 0; i < gotStreamingValues.length && false; i++) {
217217
System.out.println(
218218
"\033[32misStreaming: #" + i + ":: " + gotStreamingValues[i] + "\033[00m");
219219
}
@@ -282,14 +282,12 @@ static void massageValues(MethodAndRequestId[] mreqs) {
282282
mreq.method,
283283
mreq.requestId
284284
.withNthRequest(NON_DETERMINISTIC)
285+
.withChannelId(NON_DETERMINISTIC)
285286
.withNthClientId(NON_DETERMINISTIC));
286-
} else if (mreq.method.compareTo("google.spanner.v1.Spanner/ExecuteStreamingSql") == 0) {
287-
mreqs[i] =
288-
new MethodAndRequestId(mreq.method, mreq.requestId.withNthClientId(NON_DETERMINISTIC));
289-
} else if (mreq.method.compareTo("google.spanner.v1.Spanner/BeginTransaction") == 0) {
290-
mreqs[i] =
291-
new MethodAndRequestId(mreq.method, mreq.requestId.withNthClientId(NON_DETERMINISTIC));
292-
} else if (mreq.method.compareTo("google.spanner.v1.Spanner/ExecuteSql") == 0
287+
} else if (mreq.method.compareTo("google.spanner.v1.Spanner/BeginTransaction") == 0
288+
|| mreq.method.compareTo("google.spanner.v1.Spanner/ExecuteStreamingSql") == 0
289+
|| mreq.method.compareTo("google.spanner.v1.Spanner/ExecuteSql") == 0
290+
|| mreq.method.compareTo("google.spanner.v1.Spanner/CreateSession") == 0
293291
|| mreq.method.compareTo("google.spanner.v1.Spanner/Commit") == 0) {
294292
mreqs[i] =
295293
new MethodAndRequestId(mreq.method, mreq.requestId.withNthClientId(NON_DETERMINISTIC));

0 commit comments

Comments
 (0)