Skip to content

Conversation

@jstuyts
Copy link
Contributor

@jstuyts jstuyts commented May 15, 2020

fix: Documentation: version number and usage

Updated version number to latest release.

Improved documentation:

  • Synced Javadoc and README.md, correcting error about filter in Javadoc
  • Made example in Javadoc more easy to read and copy

Made 2 fields final to prevent editor/compiler warning.

Fixes #91

jstuyts added 2 commits May 15, 2020 08:28
Improved documentation:
- Synced Javadoc and `README.md`, correcting error about filter in Javadoc
- Made example in Javadoc more easy to read and copy
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 15, 2020
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #92   +/-   ##
=========================================
  Coverage     68.05%   68.05%           
  Complexity       35       35           
=========================================
  Files             2        2           
  Lines           144      144           
  Branches         15       15           
=========================================
  Hits             98       98           
  Misses           33       33           
  Partials         13       13           
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/logging/logback/LoggingAppender.java 67.39% <100.00%> (ø) 31.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17abe99...cd9437b. Read the comment docs.

@jstuyts jstuyts changed the title #91 Documentation improvements fix: Documentation: version number and usage May 19, 2020
@jstuyts
Copy link
Contributor Author

jstuyts commented Jun 4, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 4, 2020
@jstuyts
Copy link
Contributor Author

jstuyts commented Jun 4, 2020

@kolea2 It looks like your CI is using google-java-format built using JDK 11, but the build is started with JDK 8. The build fails because the build JDK does not understand the google-java-format class files.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2020
@kolea2
Copy link
Contributor

kolea2 commented Jun 11, 2020

Hi @jstuyts, thanks for your patience - I believe this issue should be fixed. Can you try rerunning your presubmit checks?

@jstuyts
Copy link
Contributor Author

jstuyts commented Jun 16, 2020

I spent 10 minutes trying to find the rerun button or command, but I cannot find it.

@jstuyts jstuyts closed this Jun 16, 2020
@kolea2
Copy link
Contributor

kolea2 commented Jun 16, 2020

@jstuyts I was able to rerun them! Edit: adding the GitHub workflow instructions: https://help.github.com/en/actions/configuring-and-managing-workflows/managing-a-workflow-run#viewing-your-workflow-history Unfortunately, it looks like it's still failing. @chingor13 can you help take a look here?

@jstuyts jstuyts reopened this Jun 17, 2020
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit 4ad9d23 into googleapis:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation errors in README and Javadoc

6 participants