Skip to content

Commit 36c5e0c

Browse files
committed
chore: Fix test requiring ProjectId
1 parent f775e5c commit 36c5e0c

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/test/java/com/google/cloud/logging/logback/LoggingAppenderTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
public class LoggingAppenderTest {
6363
private static final String PROJECT_ID = "test-project";
6464
private static final String CRED_FILE_PROJECT_ID = "project-12345";
65-
private static final String OVERRIDED_PROJECT_ID = "some-project-id";
65+
private static final String OVERRIDDEN_PROJECT_ID = "some-project-id";
6666
private static final String DUMMY_CRED_FILE_PATH =
6767
"src/test/java/com/google/cloud/logging/logback/dummy-credentials.json";
6868
private static final Payload.JsonPayload JSON_PAYLOAD =
@@ -295,6 +295,9 @@ public void testMdcValuesAreConvertedToLabels() {
295295
public void testCreateLoggingOptionsWithValidCredentials() {
296296
LoggingAppender appender = new LoggingAppender();
297297
appender.setCredentials(GoogleCredentials.newBuilder().build());
298+
// ServiceOptions requires a projectId to be set. Normally this is determined by the
299+
// GoogleCredentials (Credential set above is a dummy value with no ProjectId).
300+
appender.setLogDestinationProjectId(PROJECT_ID);
298301
appender.getLoggingOptions();
299302
}
300303

@@ -325,8 +328,8 @@ public void testCreateLoggingOptionsWithDestination() {
325328
// Try to build LoggingOptions with file based credentials.
326329
LoggingAppender appender = new LoggingAppender();
327330
appender.setCredentialsFile(DUMMY_CRED_FILE_PATH);
328-
appender.setLogDestinationProjectId(OVERRIDED_PROJECT_ID);
329-
assertThat(appender.getLoggingOptions().getProjectId()).isEqualTo(OVERRIDED_PROJECT_ID);
331+
appender.setLogDestinationProjectId(OVERRIDDEN_PROJECT_ID);
332+
assertThat(appender.getLoggingOptions().getProjectId()).isEqualTo(OVERRIDDEN_PROJECT_ID);
330333
}
331334

332335
private LoggingEvent createLoggingEvent(Level level, long timestamp) {

0 commit comments

Comments
 (0)