From eedd19b81870709d411de8f5d01328bea8026d75 Mon Sep 17 00:00:00 2001 From: kolea2 Date: Mon, 8 Jan 2024 09:58:26 -0500 Subject: [PATCH] deps: remove dependency on datastore-v1-proto-client module in google-cloud-datastore --- google-cloud-datastore/pom.xml | 4 ---- .../com/google/cloud/datastore/DatastoreOptions.java | 12 ++++-------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/google-cloud-datastore/pom.xml b/google-cloud-datastore/pom.xml index a4b0434eb..114e4d40d 100644 --- a/google-cloud-datastore/pom.xml +++ b/google-cloud-datastore/pom.xml @@ -42,10 +42,6 @@ com.google.api.grpc proto-google-cloud-datastore-admin-v1 - - com.google.cloud.datastore - datastore-v1-proto-client - io.grpc grpc-api diff --git a/google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java b/google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java index 37bbb0a01..0a590cc2e 100644 --- a/google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java +++ b/google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java @@ -45,6 +45,8 @@ public class DatastoreOptions extends ServiceOptions SCOPES = ImmutableSet.of(DATASTORE_SCOPE); private static final String DEFAULT_DATABASE_ID = ""; + public static final String PROJECT_ID_ENV_VAR = "DATASTORE_PROJECT_ID"; + public static final String LOCAL_HOST_ENV_VAR = "DATASTORE_EMULATOR_HOST"; private final String namespace; private final String databaseId; @@ -131,19 +133,13 @@ private DatastoreOptions(Builder builder) { @Override protected String getDefaultHost() { - String host = - System.getProperty( - com.google.datastore.v1.client.DatastoreHelper.LOCAL_HOST_ENV_VAR, - System.getenv(com.google.datastore.v1.client.DatastoreHelper.LOCAL_HOST_ENV_VAR)); + String host = System.getProperty(LOCAL_HOST_ENV_VAR, System.getenv(LOCAL_HOST_ENV_VAR)); return host != null ? host : DatastoreSettings.getDefaultEndpoint(); } @Override protected String getDefaultProject() { - String projectId = - System.getProperty( - com.google.datastore.v1.client.DatastoreHelper.PROJECT_ID_ENV_VAR, - System.getenv(com.google.datastore.v1.client.DatastoreHelper.PROJECT_ID_ENV_VAR)); + String projectId = System.getProperty(PROJECT_ID_ENV_VAR, System.getenv(PROJECT_ID_ENV_VAR)); return projectId != null ? projectId : super.getDefaultProject(); }