diff --git a/modules/ui/src/app/app.store.spec.ts b/modules/ui/src/app/app.store.spec.ts index 41bebee89..2bdf63195 100644 --- a/modules/ui/src/app/app.store.spec.ts +++ b/modules/ui/src/app/app.store.spec.ts @@ -71,7 +71,9 @@ describe('AppStore', () => { mockNotificationService = jasmine.createSpyObj('mockNotificationService', [ 'notify', ]); - mockFocusManagerService = jasmine.createSpyObj(['focusTitle']); + mockFocusManagerService = jasmine.createSpyObj([ + 'focusFirstElementInContainer', + ]); TestBed.configureTestingModule({ providers: [ @@ -214,12 +216,14 @@ describe('AppStore', () => { }); describe('setFocusOnPage', () => { - it('should call focusTitle', fakeAsync(() => { + it('should call focusFirstElementInContainer', fakeAsync(() => { appStore.setFocusOnPage(); tick(101); - expect(mockFocusManagerService.focusTitle).toHaveBeenCalled(); + expect( + mockFocusManagerService.focusFirstElementInContainer + ).toHaveBeenCalled(); })); }); }); diff --git a/modules/ui/src/app/app.store.ts b/modules/ui/src/app/app.store.ts index 0d9a6b6a1..9bd8dcff4 100644 --- a/modules/ui/src/app/app.store.ts +++ b/modules/ui/src/app/app.store.ts @@ -145,7 +145,7 @@ export class AppStore extends ComponentStore { return trigger$.pipe( delay(100), tap(() => { - this.focusManagerService.focusTitle(); + this.focusManagerService.focusFirstElementInContainer(); }) ); }); diff --git a/modules/ui/src/app/pages/risk-assessment/profile-item/profile-item.component.html b/modules/ui/src/app/pages/risk-assessment/profile-item/profile-item.component.html index 9d8d6a379..35850f0ed 100644 --- a/modules/ui/src/app/pages/risk-assessment/profile-item/profile-item.component.html +++ b/modules/ui/src/app/pages/risk-assessment/profile-item/profile-item.component.html @@ -14,30 +14,27 @@ limitations under the License. -->
- - - check_circle - - - - -
+ + + check_circle + + +

{ expect(document.activeElement).toBe(testButton); }); - - describe('#focusTitle', () => { - it('should focus title if exists', () => { - const title = document.createElement('H2'); - title.classList.add('title'); - title.tabIndex = -1; - document.querySelector('#main')?.appendChild(title); - const element = fixture.nativeElement.querySelector( - '#main .title' - ) as HTMLHeadingElement; - - service.focusTitle(); - - expect(document.activeElement).toBe(element); - }); - - it('should focus first interactive element on container if title does not exist', () => { - const testButton = fixture.nativeElement.querySelector( - '#main .test-button' - ) as HTMLButtonElement; - - service.focusTitle(); - - expect(document.activeElement).toBe(testButton); - }); - }); }); diff --git a/modules/ui/src/app/services/focus-manager.service.ts b/modules/ui/src/app/services/focus-manager.service.ts index fc4db1531..ebe3ad939 100644 --- a/modules/ui/src/app/services/focus-manager.service.ts +++ b/modules/ui/src/app/services/focus-manager.service.ts @@ -17,15 +17,6 @@ export class FocusManagerService { } } - focusTitle() { - const title = window.document.querySelector('.title') as HTMLHeadingElement; - if (title) { - title.focus(); - } else { - this.focusFirstElementInContainer(); - } - } - private findFirstInteractiveElem( parentEl: Document | Element | null ): HTMLElement | undefined | null {