From 4ac248fdcadbfff4259a70d8d1671cffedada872 Mon Sep 17 00:00:00 2001 From: Seth Vargo Date: Mon, 11 Dec 2023 13:50:48 -0500 Subject: [PATCH] Update README and CI to use latest version --- .github/workflows/cleanup.yml | 4 ++-- .github/workflows/integration.yml | 4 ++-- README.md | 31 +++++-------------------------- 3 files changed, 9 insertions(+), 30 deletions(-) diff --git a/.github/workflows/cleanup.yml b/.github/workflows/cleanup.yml index 7a36d0d7..f242a2a0 100644 --- a/.github/workflows/cleanup.yml +++ b/.github/workflows/cleanup.yml @@ -16,12 +16,12 @@ jobs: steps: - uses: 'actions/checkout@v4' - - uses: 'google-github-actions/auth@main' + - uses: 'google-github-actions/auth@v2' with: workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}' service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}' - - uses: 'google-github-actions/setup-gcloud@main' + - uses: 'google-github-actions/setup-gcloud@v2' - name: Delete services run: |- diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index cfd612fe..8c35ec45 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -48,7 +48,7 @@ jobs: - run: 'npm ci && npm run build' - - uses: 'google-github-actions/auth@main' + - uses: 'google-github-actions/auth@v2' with: workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}' service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}' @@ -126,7 +126,7 @@ jobs: - run: 'npm ci && npm run build' - - uses: 'google-github-actions/auth@main' + - uses: 'google-github-actions/auth@v2' with: workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}' service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}' diff --git a/README.md b/README.md index f48d9e2b..5073c9b5 100644 --- a/README.md +++ b/README.md @@ -36,13 +36,13 @@ jobs: steps: - uses: 'actions/checkout@v4' - - uses: 'google-github-actions/auth@v1' + - uses: 'google-github-actions/auth@v2' with: workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider' service_account: 'my-service-account@my-project.iam.gserviceaccount.com' - id: 'deploy' - uses: 'google-github-actions/deploy-cloudrun@v1' + uses: 'google-github-actions/deploy-cloudrun@v2' with: service: 'hello-cloud-run' image: 'gcr.io/cloudrun/hello' @@ -302,12 +302,12 @@ jobs: # ... - - uses: 'google-github-actions/auth@v1' + - uses: 'google-github-actions/auth@v2' with: workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider' service_account: 'my-service-account@my-project.iam.gserviceaccount.com' - - uses: 'google-github-actions/deploy-cloudrun@v1' + - uses: 'google-github-actions/deploy-cloudrun@v2' with: image: 'gcr.io/cloudrun/hello' service: 'hello-cloud-run' @@ -326,7 +326,7 @@ jobs: steps: # ... - - uses: 'google-github-actions/deploy-cloudrun@v1' + - uses: 'google-github-actions/deploy-cloudrun@v2' with: image: 'gcr.io/cloudrun/hello' service: 'hello-cloud-run' @@ -341,27 +341,6 @@ Credentials. * [Build and deploy a container](https://github.com/google-github-actions/example-workflows/blob/main/workflows/deploy-cloudrun/cloudrun-docker.yml) -## Versioning - -We recommend pinning to the latest available major version: - -```yaml -- uses: 'google-github-actions/deploy-cloudrun@v1' -``` - -While this action attempts to follow semantic versioning, but we're ultimately -human and sometimes make mistakes. To prevent accidental breaking changes, you -can also pin to a specific version: - -```yaml -- uses: 'google-github-actions/deploy-cloudrun@v1.0.0' -``` - -However, you will not get automatic security updates or new features without -explicitly updating your version number. Note that we only publish `MAJOR` and -`MAJOR.MINOR.PATCH` versions. There is **not** a floating alias for -`MAJOR.MINOR`. - [cloud-run]: https://cloud.google.com/run [sa]: https://cloud.google.com/iam/docs/creating-managing-service-accounts