Skip to content

added env_vars_separator input for overriding default comma character #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

added env_vars_separator input for overriding default comma character #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c0bf6a
added env_vars_separator input for overrading default comma character
gabrielcosi Oct 11, 2023
382c08b
generated build
gabrielcosi Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ inputs:
"env_vars" will take precendence over the keys in "env_vars_files".
required: false

env_vars_separator:
description: |-
String used to separate the env_vars for scaping comma characters.
See documentation: https://cloud.google.com/run/docs/configuring/services/environment-variables#escaping.
required: false

env_vars_file:
description: |-
Path to a file on disk, relative to the workspace, that defines
Expand Down
2 changes: 1 addition & 1 deletion dist/main/index.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export async function run(): Promise<void> {
const gcloudVersion = await computeGcloudVersion(getInput('gcloud_version'));
const gcloudComponent = presence(getInput('gcloud_component')); // Cloud SDK component version
const envVars = getInput('env_vars'); // String of env vars KEY=VALUE,...
const envVarsSeparator = getInput('env_vars_separator') || ','; // Characters to separate env_vars
const envVarsFile = getInput('env_vars_file'); // File that is a string of env vars KEY=VALUE,...
const secrets = parseKVString(getInput('secrets')); // String of secrets KEY=VALUE,...
const region = getInput('region') || 'us-central1';
Expand Down Expand Up @@ -190,7 +191,7 @@ export async function run(): Promise<void> {
// Set optional flags from inputs
const compiledEnvVars = parseKVStringAndFile(envVars, envVarsFile);
if (compiledEnvVars && Object.keys(compiledEnvVars).length > 0) {
cmd.push('--update-env-vars', kvToString(compiledEnvVars));
cmd.push('--update-env-vars', kvToString(compiledEnvVars, envVarsSeparator));
}
if (secrets && Object.keys(secrets).length > 0) {
cmd.push('--update-secrets', kvToString(secrets));
Expand Down