From 15d8dcb8400b9859bcb50bd1fed0782412b55110 Mon Sep 17 00:00:00 2001 From: evalexpr Date: Mon, 16 Mar 2020 19:42:38 +0000 Subject: [PATCH] Remove reference to golangci.com in README This project is shutting down on the 15th April. See the blog below: https://medium.com/golangci/golangci-com-is-closing-d1fc1bd30e0e --- README.md | 5 +---- README.tmpl.md | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 9a86b13fabbd..d0f0622ee1c4 100644 --- a/README.md +++ b/README.md @@ -1195,10 +1195,7 @@ By doing this you won't create new issues in your code and can choose fix existi **How to use `golangci-lint` in CI (Continuous Integration)?** -You have 2 choices: - -1. Use [GolangCI](https://golangci.com): this service is highly integrated with GitHub (issues are commented in the pull request) and uses a `golangci-lint` tool. For configuration use `.golangci.yml` (or toml/json). -2. Use custom CI: just run `golangci-lint` in CI and check the exit code. If it's non-zero - fail the build. The main disadvantage is that you can't see issues in pull request code and would need to view the build log, then open the referenced source file to see the context. +Run `golangci-lint` in CI and check the exit code. If it's non-zero - fail the build. We don't recommend vendoring `golangci-lint` in your repo: you will get troubles updating `golangci-lint`. Please, use recommended way to install with the shell script: it's very fast. diff --git a/README.tmpl.md b/README.tmpl.md index 1e2cfa1eeb9d..5c1e936e76d0 100644 --- a/README.tmpl.md +++ b/README.tmpl.md @@ -580,10 +580,7 @@ By doing this you won't create new issues in your code and can choose fix existi **How to use `golangci-lint` in CI (Continuous Integration)?** -You have 2 choices: - -1. Use [GolangCI](https://golangci.com): this service is highly integrated with GitHub (issues are commented in the pull request) and uses a `golangci-lint` tool. For configuration use `.golangci.yml` (or toml/json). -2. Use custom CI: just run `golangci-lint` in CI and check the exit code. If it's non-zero - fail the build. The main disadvantage is that you can't see issues in pull request code and would need to view the build log, then open the referenced source file to see the context. +Run `golangci-lint` in CI and check the exit code. If it's non-zero - fail the build. We don't recommend vendoring `golangci-lint` in your repo: you will get troubles updating `golangci-lint`. Please, use recommended way to install with the shell script: it's very fast.