fix #302: fix concurrent astcache access

Author: jirfag

pkg/lint/astcache/astcache.go

@@ -5,7 +5,6 @@ import (
 	"go/parser"
 	"go/token"
 	"path/filepath"
-	"strings"
 	"time"
 
 	"golang.org/x/tools/go/packages"
@@ -34,19 +33,9 @@ func NewCache(log logutils.Log) *Cache {
 }
 
 func (c Cache) Get(filename string) *File {
-	return c.m[filepath.Clean(filename)]
-}
-
-func (c Cache) keys() []string {
-	var keys []string
-	for k := range c.m {
-		keys = append(keys, k)
-	}
-	return keys
-}
-
-func (c Cache) GetOrParse(filename string, fset *token.FileSet) *File {
-	if !filepath.IsAbs(filename) {
+	if filepath.IsAbs(filename) {
+		filename = filepath.Clean(filename)
+	} else {
 		absFilename, err := filepath.Abs(filename)
 		if err != nil {
 			c.log.Warnf("Can't abs-ify filename %s: %s", filename, err)
@@ -55,14 +44,6 @@ func (c Cache) GetOrParse(filename string, fset *token.FileSet) *File {
 		}
 	}
 
-	f := c.m[filename]
-	if f != nil {
-		return f
-	}
-
-	c.log.Infof("Parse AST for file %s on demand, existing files are %s",
-		filename, strings.Join(c.keys(), ","))
-	c.parseFile(filename, fset)
 	return c.m[filename]
 }
 

pkg/result/processors/autogenerated_exclude.go

@@ -92,9 +92,9 @@ func (p *AutogeneratedExclude) getOrCreateFileSummary(i *result.Issue) (*ageFile
 		return nil, fmt.Errorf("no file path for issue")
 	}
 
-	f := p.astCache.GetOrParse(i.FilePath(), nil)
-	if f.Err != nil {
-		return nil, fmt.Errorf("can't parse file %s: %s", i.FilePath(), f.Err)
+	f := p.astCache.Get(i.FilePath())
+	if f == nil || f.Err != nil {
+		return nil, fmt.Errorf("can't parse file %s: %v", i.FilePath(), f)
 	}
 
 	autogenDebugf("file %q: astcache file is %+v", i.FilePath(), *f)

pkg/result/processors/nolint.go

@@ -87,9 +87,9 @@ func (p *Nolint) getOrCreateFileData(i *result.Issue) (*fileData, error) {
 		return nil, fmt.Errorf("no file path for issue")
 	}
 
-	file := p.astCache.GetOrParse(i.FilePath(), nil)
-	if file.Err != nil {
-		return nil, fmt.Errorf("can't parse file %s: %s", i.FilePath(), file.Err)
+	file := p.astCache.Get(i.FilePath())
+	if file == nil || file.Err != nil {
+		return nil, fmt.Errorf("can't parse file %s: %v", i.FilePath(), file)
 	}
 
 	fd.ignoredRanges = p.buildIgnoredRangesForFile(file.F, file.Fset, i.FilePath())