review

Author: ldez

pkg/golinters/asciicheck/testdata/asasalint_cgo.go renamed to pkg/golinters/asciicheck/testdata/asciicheck_cgo.go

@@ -214,8 +214,13 @@ func parseDiffLines(h *diffpkg.Hunk) []diffLine {
 	return diffLines
 }
 
-func ExtractDiagnosticFromPatch(pass *analysis.Pass, file *ast.File, patch string,
-	lintCtx *linter.Context, formatter fmtTextFormatter) error {
+func ExtractDiagnosticFromPatch(
+	pass *analysis.Pass,
+	file *ast.File,
+	patch string,
+	lintCtx *linter.Context,
+	formatter fmtTextFormatter,
+) error {
 	diffs, err := diffpkg.ParseMultiFileDiff([]byte(patch))
 	if err != nil {
 		return fmt.Errorf("can't parse patch: %w", err)

pkg/golinters/internal/diff.go

@@ -134,7 +134,7 @@ func (l Linter) Run(pass *analysis.Pass) ([]goanalysis.Issue, error) {
 				if lintersText != "" && !strings.HasPrefix(lintersText, "all") {
 					lls := strings.Split(lintersText, ",")
 					linters = make([]string, 0, len(lls))
-					rangeStart := (pos.Column - 1) + len("//") + len(leadingSpace) + len("nolint:")
+					rangeStart := (pos.Column - 1) + len(commentMark) + len(leadingSpace) + len("nolint:")
 					for i, ll := range lls {
 						rangeEnd := rangeStart + len(ll)
 						if i < len(lls)-1 {
@@ -202,7 +202,7 @@ func (l Linter) Run(pass *analysis.Pass) ([]goanalysis.Issue, error) {
 					}
 				}
 
-				if (l.needs&NeedsExplanation) != 0 && (explanation == "" || strings.TrimSpace(explanation) == "//") {
+				if (l.needs&NeedsExplanation) != 0 && (explanation == "" || strings.TrimSpace(explanation) == commentMark) {
 					needsExplanation := len(linters) == 0 // if no linters are mentioned, we must have explanation
 					// otherwise, check if we are excluding all the mentioned linters
 					for _, ll := range linters {

pkg/golinters/nolintlint/internal/nolintlint.go

@@ -33,7 +33,7 @@ func New(settings *config.NoLintLintSettings) *goanalysis.Linter {
 
 	lnt, err := nolintlint.NewLinter(needs, settings.AllowNoExplanation)
 	if err != nil {
-		internal.LinterLogger.Fatalf("asasalint: create analyzer: %v", err)
+		internal.LinterLogger.Fatalf("%s: create analyzer: %v", nolintlint.LinterName, err)
 	}
 
 	analyzer := &analysis.Analyzer{