review

Author: ldez

.golangci.yml

@@ -27,7 +27,6 @@ linters-settings:
       - ifElseChain
       - octalLiteral
       - whyNoLint
-      - wrapperFunc
   gocyclo:
     min-complexity: 15
   goimports:

pkg/golinters/lll.go

@@ -88,7 +88,7 @@ func getLLLIssuesForFile(filename string, maxLineLen int, tabSpaces string) ([]r
 	scanner := bufio.NewScanner(f)
 	for scanner.Scan() {
 		line := scanner.Text()
-		line = strings.Replace(line, "\t", tabSpaces, -1)
+		line = strings.ReplaceAll(line, "\t", tabSpaces)
 		lineLen := utf8.RuneCountInString(line)
 		if lineLen > maxLineLen {
 			res = append(res, result.Issue{

pkg/result/processors/path_shortener.go

@@ -31,8 +31,8 @@ func (p PathShortener) Name() string {
 func (p PathShortener) Process(issues []result.Issue) ([]result.Issue, error) {
 	return transformIssues(issues, func(i *result.Issue) *result.Issue {
 		newI := i
-		newI.Text = strings.Replace(newI.Text, p.wd+"/", "", -1)
-		newI.Text = strings.Replace(newI.Text, p.wd, "", -1)
+		newI.Text = strings.ReplaceAll(newI.Text, p.wd+"/", "")
+		newI.Text = strings.ReplaceAll(newI.Text, p.wd, "")
 		return newI
 	}), nil
 }

test/errchk.go

@@ -33,7 +33,7 @@ func errorCheck(outStr string, wantAuto bool, defaultWantedLinter string, fullsh
 	for i := range out {
 		for j := 0; j < len(fullshort); j += 2 {
 			full, short := fullshort[j], fullshort[j+1]
-			out[i] = strings.Replace(out[i], full, short, -1)
+			out[i] = strings.ReplaceAll(out[i], full, short)
 		}
 	}
 

test/testshared/testshared.go

@@ -154,7 +154,7 @@ func (r *LintRunner) RunCommandWithYamlConfig(cfg, command string, args ...strin
 	}
 
 	cfg = strings.TrimSpace(cfg)
-	cfg = strings.Replace(cfg, "\t", " ", -1)
+	cfg = strings.ReplaceAll(cfg, "\t", " ")
 
 	err = os.WriteFile(cfgPath, []byte(cfg), os.ModePerm)
 	assert.NoError(r.t, err)