Stop using RSA_* functions for signatures #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
changed the title
ueno
force-pushed
the
wip/rsa-evp
branch
2 times, most recently
from
40bcb96 to
8d955ba
Compare
simo5
approved these changes
Apr 7, 2023
Collaborator
simo5
left a comment
simo5
left a comment
There was a problem hiding this comment.
Looks good in general but I wonder why the change in behavior for msgIsHashed cases, I think we wanted to enforce hashing in the FIPS boundary in the past?
Collaborator
Author
|
Afaik we later had to revert that enforcement as the crypto/rsa.SignPKCS1v15 takes hashed bytes and there are still some use of PKCS#1 v1.5 signatures in applications. |
For creating and verifying PKCS#1 v1.5 signatures in a pre-hashed
manner, we used the legacy RSA_sign and RSA_verify functions, which
bypass the system-wide disablement of SHA-1 and shorter RSA key length
usage inconsistently with the OpenSSL 3.0 default on RHEL.
This switches to using our _goboringcrypto_EVP_{sign,verify}_raw,
which internally use EVP_PKEY_ functions.
Signed-off-by: Daiki Ueno <[email protected]>
This switches _goboringcrypto_RSA_generate_key_fips to using EVP_PKEY_keygen function instead of RSA_generate_key_ex. The accessors functions around the RSA * type, such as RSA_get0_crt_params, are still used, though they are not a cryptographic operation so this patch leaves it as they are for now. Signed-off-by: Daiki Ueno <[email protected]>
Signed-off-by: Daiki Ueno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For creating and verifying PKCS#1 v1.5 signatures in a pre-hashed manner, we used the legacy
RSA_signandRSA_verifyfunctions, which bypass the system-wide disablement of SHA-1 and shorter RSA key length usage inconsistently with the OpenSSL 3.0 default on RHEL.This switches to using our
_goboringcrypto_EVP_{sign,verify}_raw, which internally useEVP_PKEY_functions.