Merge pull request #1767 from Zylann/quaterion_abs

dsnopek · web-flow · commit 94a8fad88cd5 · 2025-04-15T08:12:53.000-05:00
Use Math::abs to avoid ambiguity with integer abs
diff --git a/include/godot_cpp/variant/quaternion.hpp b/include/godot_cpp/variant/quaternion.hpp
@@ -149,7 +149,7 @@ struct [[nodiscard]] Quaternion {
 		Vector3 n0 = p_v0.normalized();
 		Vector3 n1 = p_v1.normalized();
 		real_t d = n0.dot(n1);
-		if (abs(d) > ALMOST_ONE) {
+		if (Math::abs(d) > ALMOST_ONE) {
 			if (d >= 0) {
 				return; // Vectors are same.
 			}

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ struct [[nodiscard]] Quaternion {`
`149`	`149`	`Vector3 n0 = p_v0.normalized();`
`150`	`150`	`Vector3 n1 = p_v1.normalized();`
`151`	`151`	`real_t d = n0.dot(n1);`
`152`		`- if (abs(d) > ALMOST_ONE) {`
	`152`	`+ if (Math::abs(d) > ALMOST_ONE) {`
`153`	`153`	`if (d >= 0) {`
`154`	`154`	`return; // Vectors are same.`
`155`	`155`	`}`