Fix shell argument limit

Author: ze2j

tools/common_compiler_flags.py

@@ -121,3 +121,6 @@ def generate(env):
         elif env["lto"] == "full":
             env.Append(CCFLAGS=["-flto"])
             env.Append(LINKFLAGS=["-flto"])
+
+        if env["platform"] == "linux":
+            env['ARFLAGS'] = "rcs"

tools/godotcpp.py

@@ -1,5 +1,6 @@
 import os
 import platform
+import tempfile
 import sys
 
 from SCons.Action import Action
@@ -162,6 +163,23 @@ def scons_generate_bindings(target, source, env):
     return None
 
 
+def _build_static_lib_with_rsp(target, source, env):
+    target_lib = str(target[0])
+    rsp_fd, rsp_path = tempfile.mkstemp(suffix=".rsp")
+    os.close(rsp_fd)
+    try:
+        with open(rsp_path, "w") as rsp_file:
+            for src in source:
+                rsp_file.write(str(src) + "\n")
+        ar = env['AR']
+        arflags = env.get("ARFLAGS", "")
+        command = "{} {} {} @{}".format(ar, arflags, target_lib, rsp_path)
+        env.Execute(command)
+    finally:
+        os.remove(rsp_path)
+    return None
+
+
 platforms = ["linux", "macos", "windows", "android", "ios", "web"]
 
 # CPU architecture options.
@@ -513,6 +531,9 @@ def generate(env):
             "GodotCPPDocData": Builder(action=scons_generate_doc_source),
         }
     )
+    if env["platform"] == "linux":
+        env.Append(BUILDERS={"GodotStaticLibRspBuilder": Builder(action=Action(_build_static_lib_with_rsp, "$ARCOMSTR"))})
+
     env.AddMethod(_godot_cpp, "GodotCPP")
 
 
@@ -547,7 +568,13 @@ def _godot_cpp(env):
     library_name = "libgodot-cpp" + env["suffix"] + env["LIBSUFFIX"]
 
     if env["build_library"]:
-        library = env.StaticLibrary(target=env.File("bin/%s" % library_name), source=sources)
+        if env["platform"] == "linux":
+            # Use a custom builder to aggregate object files into a static library using a temporary response file.
+            # This avoids hitting the shell argument limit.
+            library = env.GodotStaticLibRspBuilder(target=env.File("bin/%s" % library_name), source=env.Object(sources))
+        else:
+            library = env.StaticLibrary(target=env.File("bin/%s" % library_name), source=sources)
+
         env.NoCache(library)
         default_args = [library]