fix(mangler): name mangler panics on trailing pluralized initialisms

This fix correctly detects this situation and avoid an out of range
check.

* fixes #158

Signed-off-by: Frederic BIDON <[email protected]>

Author: fredbi

mangling/initialism_index.go

@@ -179,6 +179,19 @@ const (
 	simplePlural
 )
 
+func (f pluralForm) String() string {
+	switch f {
+	case notPlural:
+		return "notPlural"
+	case invariantPlural:
+		return "invariantPlural"
+	case simplePlural:
+		return "simplePlural"
+	default:
+		return "<unknown>"
+	}
+}
+
 // pluralForm indicates how we want to pluralize a given initialism.
 //
 // Besides configured invariant forms (like HTTP and HTTPS),

mangling/name_mangler_test.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 
 	"github.com/go-openapi/testify/v2/assert"
+	"github.com/go-openapi/testify/v2/require"
 )
 
 const (
@@ -24,6 +25,16 @@ const (
 	sampleUscore = "sample_"
 )
 
+func TestManglerToGoName_Issue158(t *testing.T) {
+	m := NewNameMangler()
+
+	t.Run("should detect trailing pluralized initialisms", func(t *testing.T) {
+		require.Equal(t, "LinkLocalIPs", m.ToGoName("LinkLocalIPs"))
+		require.Equal(t, "NativeBaseURLs", m.ToGoName("nativeBaseURLs"))
+		require.Equal(t, "SiteURLs", m.ToGoName("siteURLs"))
+	})
+}
+
 func TestManglerToGoName(t *testing.T) {
 	m := NewNameMangler()
 

mangling/split.go

@@ -90,6 +90,11 @@ func (s splitter) gatherInitialismMatches(nameRunes []rune) *initialismMatches {
 					continue
 				}
 
+				if currentRunePosition-match.start == len(match.body) {
+					// unmatched: skip
+					continue
+				}
+
 				currentMatchRune := match.body[currentRunePosition-match.start]
 				if currentMatchRune != currentRune {
 					// failed match, move on to next rune
@@ -160,7 +165,7 @@ func (s splitter) gatherInitialismMatches(nameRunes []rune) *initialismMatches {
 			}
 		}
 
-		// check for new initialism matches
+		// check for new initialism matches, based on the first character
 		for i, r := range s.initialismsRunes {
 			if r[0] == currentRune {
 				*newMatches = append(*newMatches, initialismMatch{