Skip to content

Fix UI misalignment on user setting page #25629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Fix UI misalignment on user setting page #25629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec9d897
fix
wxiaoguang Jul 2, 2023
32971c3
Merge branch 'main' into fix-user-setting
GiteaBot Jul 3, 2023
29cbaef
Merge branch 'main' into fix-user-setting
GiteaBot Jul 3, 2023
118d42e
Merge branch 'main' into fix-user-setting
GiteaBot Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions templates/user/settings/account.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,21 +39,15 @@
{{.locale.Tr "settings.manage_emails"}}
</h4>
<div class="ui attached segment">
<div class="ui email list">
<div class="ui list">
{{if $.EnableNotifyMail}}
<div class="item">
<div class="gt-mb-3">{{.locale.Tr "settings.email_desc"}}</div>
<form action="{{AppSubUrl}}/user/settings/account/email" class="ui form" method="post">
{{.locale.Tr "settings.email_desc"}}
<div class="right floated content">
<div class="field">
<button class="ui green button">{{$.locale.Tr "settings.email_notifications.submit"}}</button>
</div>
</div>
<div class="right floated content">
{{$.CsrfTokenHtml}}
<input name="_method" type="hidden" value="NOTIFICATION">
<div class="field">
<div class="ui selection dropdown" tabindex="0">
<div class="gt-df gt-fw gt-gap-3">
<div class="ui selection dropdown">
<input name="preference" type="hidden" value="{{.EmailNotificationsPreference}}">
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
<div class="text"></div>
Expand All @@ -64,7 +58,7 @@
<div data-value="disabled" class="{{if eq .EmailNotificationsPreference "disabled"}}active selected {{end}}item">{{$.locale.Tr "settings.email_notifications.disable"}}</div>
</div>
</div>
</div>
<button class="ui green button">{{$.locale.Tr "settings.email_notifications.submit"}}</button>
</div>
</form>
</div>
Expand Down Expand Up @@ -102,7 +96,7 @@
</form>
</div>
{{end}}
<div class="content">
<div class="content gt-py-3">
<strong>{{.Email}}</strong>
{{if .IsPrimary}}
<div class="ui primary label">{{$.locale.Tr "settings.primary"}}</div>
Expand Down
23 changes: 12 additions & 11 deletions templates/user/settings/applications_oauth2_list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,19 @@
</div>
{{end}}
</div>

<div class="ui g-modal-confirm delete modal" id="remove-gitea-oauth2-application">
<div class="header">
{{svg "octicon-trash"}}
{{.locale.Tr "settings.remove_oauth2_application"}}
</div>
<div class="content">
<p>{{.locale.Tr "settings.oauth2_application_remove_description"}}</p>
</div>
{{template "base/modal_actions_confirm" .}}
</div>
</div>

<div class="ui attached bottom segment">
<h5 class="ui top header">
{{.locale.Tr "settings.create_oauth2_application"}}
Expand All @@ -46,14 +58,3 @@
</button>
</form>
</div>

<div class="ui g-modal-confirm delete modal" id="remove-gitea-oauth2-application">
<div class="header">
{{svg "octicon-trash"}}
{{.locale.Tr "settings.remove_oauth2_application"}}
</div>
<div class="content">
<p>{{.locale.Tr "settings.oauth2_application_remove_description"}}</p>
</div>
{{template "base/modal_actions_confirm" .}}
</div>
2 changes: 1 addition & 1 deletion templates/user/settings/grants_oauth2.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
</div>
{{end}}
</div>
</div>

<div class="ui g-modal-confirm delete modal" id="revoke-gitea-oauth2-grant">
<div class="header">
Expand All @@ -38,3 +37,4 @@
</div>
{{template "base/modal_actions_confirm" .}}
</div>
</div>
2 changes: 1 addition & 1 deletion templates/user/settings/security/accountlinks.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
</div>
{{end}}
</div>
</div>

<div class="ui g-modal-confirm delete modal" id="delete-account-link">
<div class="header">
Expand All @@ -51,4 +50,5 @@
</div>
{{template "base/modal_actions_confirm" .}}
</div>
</div>
{{end}}
2 changes: 1 addition & 1 deletion templates/user/settings/security/openid.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
{{.locale.Tr "settings.add_openid"}}
</button>
</form>
</div>

<div class="ui g-modal-confirm delete modal" id="delete-openid">
<div class="header">
Expand All @@ -60,3 +59,4 @@
</div>
{{template "base/modal_actions_confirm" .}}
</div>
</div>
2 changes: 1 addition & 1 deletion templates/user/settings/security/twofa.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
<a class="ui green button" href="{{AppSubUrl}}/user/settings/security/two_factor/enroll">{{$.locale.Tr "settings.twofa_enroll"}}</a>
</div>
{{end}}
</div>

<div class="ui g-modal-confirm delete modal" id="disable-twofa">
<div class="header">
Expand All @@ -33,3 +32,4 @@
</div>
{{template "base/modal_actions_confirm" .}}
</div>
</div>
3 changes: 1 addition & 2 deletions templates/user/settings/security/webauthn.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
</div>
<button id="register-webauthn" class="ui green button">{{svg "octicon-key"}} {{.locale.Tr "settings.webauthn_register_key"}}</button>
</div>
</div>

<div class="ui g-modal-confirm delete modal" id="delete-registration">
<div class="header">
{{svg "octicon-trash"}}
Expand All @@ -36,3 +34,4 @@
</div>
{{template "base/modal_actions_confirm" .}}
</div>
</div>
4 changes: 0 additions & 4 deletions web_src/css/repo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2358,10 +2358,6 @@
color: var(--color-text-light-2);
}

.settings .list.email > .item:not(:first-child) {
min-height: 60px;
}

.settings .list.collaborator > .item {
padding: 0;
}
Expand Down