Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Jul 20, 2020

as title

@6543 6543 changed the title [WIP] Update gitea-vet to v0.2.0 Update gitea-vet to v0.2.0 Jul 21, 2020
@6543
Copy link
Member Author

6543 commented Jul 21, 2020

blocked by #11646

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2020
@6543
Copy link
Member Author

6543 commented Jul 21, 2020

blocked by #12286

@6543

This comment has been minimized.

@mrsdizzie
Copy link
Member

can we ignore old migrations and only apply this rule to newer ones? it feels very wrong and error-prone to go back and re-write dozens of old migrations that have been working for a while

@6543
Copy link
Member Author

6543 commented Jul 26, 2020

@mrsdizzie at this point this are indirect dependencys

for example on v70: the setting.Service.DefaultEnableDependencies value is used.
setting.Service struct as one field (not that one) who is a type decrlared in structs

So my suggestion where: for dependencys: ignores structs and just deny direct imports for structs

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 8, 2020
@lunny
Copy link
Member

lunny commented Aug 8, 2020

Just ignore the previous is better I think. Maybe we need a white list for these files on vet to do that.

@6543
Copy link
Member Author

6543 commented Aug 15, 2020

@6543 6543 changed the title Update gitea-vet to v0.2.0 Update gitea-vet to v0.2.1 Aug 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 15, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12282 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12282   +/-   ##
=======================================
  Coverage   43.76%   43.76%           
=======================================
  Files         631      631           
  Lines       69870    69870           
=======================================
+ Hits        30580    30582    +2     
+ Misses      34338    34336    -2     
  Partials     4952     4952           
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/avatar/avatar.go 50.00% <0.00%> (-4.77%) ⬇️
services/pull/pull.go 42.26% <0.00%> (+0.23%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
services/pull/update.go 57.69% <0.00%> (+5.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb60a5d...1a5b2f4. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Aug 15, 2020

🚀

@techknowlogick techknowlogick merged commit ee97e6a into go-gitea:master Aug 15, 2020
@6543 6543 deleted the update_gitea-vet branch August 15, 2020 22:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants