Skip to content

Fix repolist icons #12228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2020
Merged

Fix repolist icons #12228

merged 1 commit into from
Jul 12, 2020

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Jul 12, 2020 •
edited
Loading

We should really extract this file to its own .vue template as having multiple template languages in one file is majorly confusing.

Fixes: #12226

@silverwind
Copy link
Member Author

silverwind commented Jul 12, 2020 •
edited
Loading

Something for later (after extracting to standalone vue component):

https://github.com/visualfanatic/vue-svg-loader

(It'll require some webpack fiddling to import multiple versions of the same svg file. I know https://github.com/facebook/create-react-app has solved to using import {ReactComponent} as Icon syntax), e.g. facebook/create-react-app@d0e1731.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 12, 2020
@silverwind silverwind force-pushed the dashicons branch 3 times, most recently from 25d25ed to d6e11f5 Compare July 12, 2020 20:53
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 12, 2020
zeripath
zeripath reviewed Jul 12, 2020
View reviewed changes
silverwind
silverwind commented Jul 12, 2020
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 12, 2020
@lafriks lafriks added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 12, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jul 12, 2020
@lafriks lafriks merged commit 48ad76c into go-gitea:master Jul 12, 2020
@silverwind silverwind deleted the dashicons branch July 13, 2020 05:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

Octicons are missing for dashboard repolist

4 participants

@silverwind @lafriks @zeripath @GiteaBot