From 103c9e97113d0c50a450a9ceadbb2052ca60f095 Mon Sep 17 00:00:00 2001 From: CirnoT <1447794+CirnoT@users.noreply.github.com> Date: Fri, 15 May 2020 23:21:06 +0200 Subject: [PATCH 1/5] Better styling for code review comment textarea --- web_src/less/_review.less | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/web_src/less/_review.less b/web_src/less/_review.less index 5d137e0c60067..9df25d4510718 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -62,16 +62,11 @@ cursor: pointer; } - .ui.form textarea { - border: 0; - } - - .ui.attached.tabular.menu { - background: #f7f7f7; - border: 1px solid #d4d4d5; + .ui.tabular.menu { padding-top: 5px; padding-left: 5px; - margin-top: 0; + margin-bottom: 0; + border-bottom: 0; } .footer { From f7f2ee6946aaa1991f3a917b8a9f6204c57a4873 Mon Sep 17 00:00:00 2001 From: CirnoT <1447794+CirnoT@users.noreply.github.com> Date: Sat, 16 May 2020 01:54:42 +0200 Subject: [PATCH 2/5] align tabular menu with textarea --- web_src/less/_review.less | 2 -- 1 file changed, 2 deletions(-) diff --git a/web_src/less/_review.less b/web_src/less/_review.less index 0fd79d69a03eb..f2a3c60eabaaa 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -63,8 +63,6 @@ } .ui.tabular.menu { - padding-top: 5px; - padding-left: 5px; margin-bottom: 0; border-bottom: 0; } From 9595fdd610b1f9c88a9c029f4bfac41ff00cbecf Mon Sep 17 00:00:00 2001 From: CirnoT <1447794+CirnoT@users.noreply.github.com> Date: Sat, 16 May 2020 15:05:19 +0200 Subject: [PATCH 3/5] border around active tab instead of textarea --- web_src/less/_review.less | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/web_src/less/_review.less b/web_src/less/_review.less index f2a3c60eabaaa..68767479d3a2e 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -62,6 +62,15 @@ cursor: pointer; } + .ui.form textarea { + border: 0; + } + + .ui.active.tab { + border: 1px solid #d4d4d5; + padding: .5em; + } + .ui.tabular.menu { margin-bottom: 0; border-bottom: 0; From 0578a6aebe74d61b78bc36762615ca4293c000c6 Mon Sep 17 00:00:00 2001 From: CirnoT <1447794+CirnoT@users.noreply.github.com> Date: Sat, 16 May 2020 15:43:44 +0200 Subject: [PATCH 4/5] border radius --- web_src/less/_review.less | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/web_src/less/_review.less b/web_src/less/_review.less index 68767479d3a2e..a22ae86ecf4ad 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -69,6 +69,11 @@ .ui.active.tab { border: 1px solid #d4d4d5; padding: .5em; + border-radius: 0 .28rem .28rem .28rem; + } + + .ui.active.markdown.tab { + border-top-left-radius: .28rem; } .ui.tabular.menu { From df0ca2835e88b84ae2d36441bfe69ada0e725cb8 Mon Sep 17 00:00:00 2001 From: CirnoT <1447794+CirnoT@users.noreply.github.com> Date: Sat, 16 May 2020 16:57:00 +0200 Subject: [PATCH 5/5] use .28571429rem --- web_src/less/_review.less | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web_src/less/_review.less b/web_src/less/_review.less index a22ae86ecf4ad..f146cc1da8a0e 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -69,11 +69,11 @@ .ui.active.tab { border: 1px solid #d4d4d5; padding: .5em; - border-radius: 0 .28rem .28rem .28rem; + border-radius: 0 .28571429rem .28571429rem .28571429rem; } .ui.active.markdown.tab { - border-top-left-radius: .28rem; + border-top-left-radius: .28571429rem; } .ui.tabular.menu {