Skip to content

Commit 484924a

Browse files
committed
README.md
1 parent 986d51d commit 484924a

File tree

2 files changed

+7
-56
lines changed

2 files changed

+7
-56
lines changed

README.md

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ Test / jsEnv := new PWEnv(
2424
// For Scala.js 1.x
2525
scalaJSLinkerConfig ~= { _.withModuleKind(ModuleKind.ESModule) }
2626
```
27-
* Some projects which may need to use both Selenium and Playwright. If it runs into google exception, add the following line to your `plugins.sbt`
27+
* Some projects which may need to use both Selenium and Playwright.
28+
If it runs into google exception, add the following line to your `plugins.sbt`
2829
```scala
2930
libraryDependencies += "com.google.guava" % "guava" % "33.0.0-jre"
3031
```
@@ -33,7 +34,7 @@ libraryDependencies += "com.google.guava" % "guava" % "33.0.0-jre"
3334
* chrome
3435
* chromium (same as chrome)
3536
* firefox
36-
* webkit (experimental)
37+
* webkit (experimental) - Works will on macOS. Mileage may vary on other platforms.
3738

3839
## Compatibility notes
3940
### Scala versions
@@ -56,34 +57,12 @@ jsEnv := new jsenv.playwright.PWEnv(
5657
```
5758

5859
## KeepAlive configuration
59-
```scala
60-
lazy val pwenvConfig = Def.setting {
61-
jsenv.playwright.PWEnv
62-
.Config()
63-
.withKeepAlive(false)
64-
}
65-
66-
jsEnv := new jsenv.playwright.PWEnv(
67-
browserName = "chrome",
68-
headless = true,
69-
showLogs = true,
70-
pwenvConfig.value,
71-
)
72-
73-
```
60+
It is work in progress.
61+
As a workaround introducing delay in the test cases may help to keep the browser alive.
7462

7563
## Wiki
7664
Watch this space for more details on how to use this library.
7765

7866
## References
7967
* Sample project using this JSEnv: https://github.com/gmkumar2005/scalajs-sbt-vite-laminar-chartjs-example
8068

81-
## Todo
82-
* Add examples to demonstrate how to use LaunchOptions
83-
* ~~Add feature to keepAlive the browser~~
84-
* Optimize to use a single browser instance for all tests by creating multiple tabs
85-
* ~~Configure github actions to test this project~~
86-
* Configure github actions to publish to maven central
87-
* Verify debug mode works
88-
* Verify other test frameworks work
89-
* Verify it works on windows and Linux

build.sbt

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,10 @@ lazy val root = (project in file("."))
5252
setReleaseVersion,
5353
commitReleaseVersion,
5454
tagRelease,
55-
publishArtifacts,
55+
ReleaseStep(action = Command.process("publishSigned", _)),
5656
setNextVersion,
5757
commitNextVersion
5858
),
59-
// publishTo := sonatypePublishToBundle.value,
6059
publishTo := {
6160
val nexus = "https://s01.oss.sonatype.org/"
6261
if (isSnapshot.value)
@@ -66,36 +65,9 @@ lazy val root = (project in file("."))
6665
},
6766
// For all Sonatype accounts created on or after February 2021
6867
sonatypeCredentialHost := "s01.oss.sonatype.org",
69-
// pomExtra := _pomExtra,
7068
Test / parallelExecution := false,
7169
Test / publishArtifact := false,
7270
usePgpKeyHex("F7E440260BAE93EB4AD2723D6613CA76E011F638")
73-
74-
// sonatypeRepository := "https://oss.sonatype.org/service/local"
75-
// sonatypeRepository := "https://s01.oss.sonatype.org/service/local"
7671
)
7772

78-
val _pomExtra =
79-
<url>https://github.com/gmkumar2005/scala-js-env-playwright</url>
80-
<licenses>
81-
<license>
82-
<name>Apache License, Version 2.0</name>
83-
<url>http://www.apache.org/licenses/LICENSE-2.0.html</url>
84-
<distribution>repo</distribution>
85-
</license>
86-
</licenses>
87-
<scm>
88-
<url>git@github.com:gmkumar2005/scala-js-env-playwright.git</url>
89-
<connection>scm:git:git@github.com:gmkumar2005/scala-js-env-playwright.git</connection>
90-
</scm>
91-
<developers>
92-
<developer>
93-
<id>gmkumar2005</id>
94-
<name>Kiran Kumar</name>
95-
<url>https://github.com/gmkumar2005</url>
96-
</developer>
97-
</developers>
98-
<issueManagement>
99-
<system>GitHub</system>
100-
<url>https://github.com/gmkumar2005/scala-js-env-playwright/issues</url>
101-
</issueManagement>
73+

0 commit comments

Comments
 (0)