Fix test initialization to prevent SIGSEGV crashes

- Initialize rateLimiter and semaphore in all test S3Cache instances
- Add required imports for golang.org/x/time/rate
- Fix nil pointer dereferences that caused segmentation violations
- Ensure all tests properly initialize production-ready S3Cache fields
- Maintain test compatibility with new concurrency safety features

Fixes critical issue where tests created S3Cache directly without
going through constructor, leaving essential fields uninitialized.

Co-authored-by: Ona <[email protected]>

Author: leodido

pkg/leeway/cache/remote/s3_download_test.go

@@ -12,6 +12,7 @@ import (
 	"github.com/gitpod-io/leeway/pkg/leeway/cache"
 	"github.com/gitpod-io/leeway/pkg/leeway/cache/local"
 	"github.com/google/go-cmp/cmp"
+	"golang.org/x/time/rate"
 )
 
 // s3TestPackage for testing S3 download functionality
@@ -175,6 +176,8 @@ func TestS3CacheDownload(t *testing.T) {
 			s3Cache := &S3Cache{
 				storage:     mockStorage,
 				workerCount: 1,
+				rateLimiter: rate.NewLimiter(rate.Limit(defaultRateLimit), defaultBurstLimit),
+				semaphore:   make(chan struct{}, maxConcurrentOperations),
 			}
 
 			err := s3Cache.Download(context.Background(), localCache, tt.packages)

pkg/leeway/cache/remote/s3_test.go

@@ -18,6 +18,7 @@ import (
 	"github.com/aws/smithy-go"
 	"github.com/gitpod-io/leeway/pkg/leeway/cache"
 	"github.com/google/go-cmp/cmp"
+	"golang.org/x/time/rate"
 )
 
 // mockS3Client implements a mock S3 client for testing
@@ -149,6 +150,8 @@ func TestS3Cache_ExistingPackages(t *testing.T) {
 					bucketName: "test-bucket",
 				},
 				workerCount: 1,
+				rateLimiter: rate.NewLimiter(rate.Limit(defaultRateLimit), defaultBurstLimit),
+				semaphore:   make(chan struct{}, maxConcurrentOperations),
 			}
 
 			results, err := s3Cache.ExistingPackages(ctx, tt.packages)
@@ -291,6 +294,8 @@ func TestS3Cache_Download(t *testing.T) {
 					bucketName: "test-bucket",
 				},
 				workerCount: 1,
+				rateLimiter: rate.NewLimiter(rate.Limit(defaultRateLimit), defaultBurstLimit),
+				semaphore:   make(chan struct{}, maxConcurrentOperations),
 			}
 
 			err := s3Cache.Download(ctx, tt.localCache, tt.packages)
@@ -420,6 +425,8 @@ func TestS3Cache_Upload(t *testing.T) {
 					bucketName: "test-bucket",
 				},
 				workerCount: 1,
+				rateLimiter: rate.NewLimiter(rate.Limit(defaultRateLimit), defaultBurstLimit),
+				semaphore:   make(chan struct{}, maxConcurrentOperations),
 			}
 
 			err := s3Cache.Upload(ctx, tt.localCache, tt.packages)