fixing lint errors (#17156)

Author: selfcontained

components/dashboard/src/admin/License.tsx

@@ -11,9 +11,6 @@ import { getGitpodService } from "../service/service";
 import { ReactComponent as Alert } from "../images/exclamation.svg";
 import { ReactComponent as Success } from "../images/check-circle.svg";
 import { LicenseInfo } from "@gitpod/gitpod-protocol";
-import { ReactComponent as XSvg } from "../images/x.svg";
-import { ReactComponent as CheckSvg } from "../images/check.svg";
-import { ReactComponent as LinkSvg } from "../images/external-link.svg";
 import SolidCard from "../components/SolidCard";
 import Card from "../components/Card";
 import { isGitpodIo } from "../utils";

components/dashboard/src/admin/ProjectsSearch.tsx

@@ -50,6 +50,7 @@ export function ProjectsSearch() {
         } else {
             setCurrentProject(undefined);
         }
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [location]);
 
     useEffect(() => {

components/dashboard/src/admin/Settings.tsx

@@ -44,6 +44,7 @@ export default function Settings() {
             const setting = await getGitpodService().server.adminGetSettings();
             setAdminSettings(setting);
         })();
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, []);
 
     const actuallySetTelemetryPrefs = async (value: InstallationAdminSettings) => {

components/dashboard/src/admin/TeamsSearch.tsx

@@ -52,6 +52,7 @@ export function TeamsSearch() {
         } else {
             setCurrentTeam(undefined);
         }
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [location]);
 
     if (currentTeam) {

components/dashboard/src/admin/UserDetail.tsx

@@ -473,7 +473,7 @@ function renderBillingModeProperty(billingMode?: BillingMode): JSX.Element {
                     >
                         <p className="flex justify-left text-gitpod-red">
                             <span>UBP blocked by:</span>
-                            <img className="m-2" src={CaretDown} />
+                            <img className="m-2" src={CaretDown} alt="caret icon pointing down" />
                         </p>
                     </ContextMenu>
                 )}

components/dashboard/src/admin/UserSearch.tsx

@@ -40,6 +40,7 @@ export default function UserSearch() {
         } else {
             setCurrentUserState(undefined);
         }
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [location]);
 
     if (currentUser) {

components/dashboard/src/admin/WorkspacesSearch.tsx

@@ -66,12 +66,14 @@ export function WorkspaceSearch(props: Props) {
         } else {
             setCurrentWorkspaceState(undefined);
         }
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [location]);
 
     useEffect(() => {
         if (props.user) {
             search();
         }
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [props.user]);
 
     if (currentWorkspace) {

components/dashboard/src/components/ConfirmationModal.tsx

@@ -35,6 +35,7 @@ export default function ConfirmationModal(props: {
     const buttonDisabled = useRef(props.buttonDisabled);
     useEffect(() => {
         buttonDisabled.current = props.buttonDisabled;
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, []);
 
     return (

components/dashboard/src/components/ContextMenu.tsx

@@ -36,16 +36,6 @@ export interface ContextMenuEntry {
 function ContextMenu(props: ContextMenuProps) {
     const [expanded, setExpanded] = useState(false);
 
-    const { changeMenuState } = props;
-
-    useEffect(() => {
-        return () => {
-            if (changeMenuState) {
-                changeMenuState(!expanded);
-            }
-        };
-    }, [expanded]);
-
     const toggleExpanded = () => {
         setExpanded(!expanded);
         if (props.changeMenuState) {
@@ -80,6 +70,7 @@ function ContextMenu(props: ContextMenuProps) {
             window.removeEventListener("keydown", keydownHandler);
             window.removeEventListener("click", clickHandler);
         };
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, []); // Empty array ensures that effect is only run on mount and unmount
 
     // Default 'children' is the three dots hamburger button.

components/dashboard/src/components/DropDown2.tsx

@@ -108,7 +108,7 @@ export const DropDown2: FunctionComponent<DropDown2Props> = (props) => {
                 e.preventDefault();
             }
         },
-        [filteredOptions, props, selectedElementTemp, setFocussedElement, showDropDown, toggleDropDown],
+        [filteredOptions, props, search, selectedElementTemp, setFocussedElement, showDropDown, toggleDropDown],
     );
 
     const handleBlur = useCallback(