This repository was archived by the owner on May 30, 2024. It is now read-only.
Add 'deployable_ref' field for the validation of ref #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahingh
added
the
component: server
Closed
noahingh
commented
Nov 18, 2021
Comment on lines
+175
to
+179
| if ok, err := env.IsDeployableRef(d.Ref); err != nil { | ||
| return false, err | ||
| } else if !ok { | ||
| return false, e.NewErrorWithMessage(e.ErrorCodeUnprocessableEntity, "The ref is not matched with 'deployable_ref'.", nil) | ||
| } |
Member
Author
There was a problem hiding this comment.
Validate the ref is matched with deployable_ref or not.
Comment on lines
+11
to
+12
| // ErrorCodeConfigRegexpError is the regexp(re2) is invalid. | ||
| ErrorCodeConfigRegexpError ErrorCode = "config_regexp_error" |
Member
Author
There was a problem hiding this comment.
Add a new error config_regexp_error to describe an error from the regexp.MatchString
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
deployable_reffield to the configuration to validate the ref which is deployable or not. If it is not matched, it returns an unprocessable entity error.