Groups: add support for custom attributes #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom attributes on groups (https://docs.gitlab.com/ce/api/custom_attributes.html). It's mostly copy and paste from what have been done from the projects. It fixes #769
I ended up using the
TEST_GROUPproperties in the tests, is that okay? I've added it as mandatory in theAbstractIntegrationTest::baseTestSetup()method. I did not edit thesrc/test/resources/test-gitlab4j.propertiesfile to reflect that it is also used to test custom attributes, should I?Let me know what you think of this!