Use status code 200 instead of 201. #221 #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitLab API returns 200 in the case of an update.
Collaborator
|
@RAYs3T |
Collaborator
|
@RAYs3T I did a scan of all put() calls in the project and found 2 additional places that CREATED needed to be changed to OK. You might want to pull an update. |
Contributor
Author
|
@gmessner Thanks for the fast merge! |
Collaborator
|
@RAYs3T |
Contributor
Author
|
@gmessner Missed that one :3 - but well then we are fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitLab API returns 200 in the case of an update, not 201.
closes #221