Adds a new updateMergeRequest method with more attributes #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@armsnyder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deprecated the existing updateMergeRequest method and added a new updateMergeRequest method which accepts more parameters. These new parameters correspond to the attributes listed here that were previously not settable.
Closes #205
Since there were now 3 different updateMergeRequest methods which contained duplicated code, I abstracted the common logic to a protected method
The reason it is protected and not private is so that in the future, users of this library can extend the class to add new attributes themselves, instead of waiting for the library to update. I'm curious if making it a public method would be preferable.