Added encoding to the tag name where the tag name is used in the url path (#372)

* Added encoding to the tag name where the tag name is used in the URL path

Author: chrisrohr

src/main/java/org/gitlab4j/api/TagsApi.java

@@ -94,7 +94,7 @@ public Stream<Tag> getTagsStream(Object projectIdOrPath) throws GitLabApiExcepti
      * @throws GitLabApiException if any exception occurs
      */
     public Tag getTag(Object projectIdOrPath, String tagName) throws GitLabApiException {
-        Response response = get(Response.Status.OK, null, "projects", getProjectIdOrPath(projectIdOrPath), "repository", "tags", tagName);
+        Response response = get(Response.Status.OK, null, "projects", getProjectIdOrPath(projectIdOrPath), "repository", "tags", urlEncode(tagName));
         return (response.readEntity(Tag.class));
     }
 
@@ -198,7 +198,7 @@ public Tag createTag(Object projectIdOrPath, String tagName, String ref, String
      */
     public void deleteTag(Object projectIdOrPath, String tagName) throws GitLabApiException {
         Response.Status expectedStatus = (isApiVersion(ApiVersion.V3) ? Response.Status.OK : Response.Status.NO_CONTENT);
-        delete(expectedStatus, null, "projects", getProjectIdOrPath(projectIdOrPath), "repository", "tags", tagName);
+        delete(expectedStatus, null, "projects", getProjectIdOrPath(projectIdOrPath), "repository", "tags", urlEncode(tagName));
     }
 
     /**
@@ -215,7 +215,7 @@ public void deleteTag(Object projectIdOrPath, String tagName) throws GitLabApiEx
     public Release createRelease(Object projectIdOrPath, String tagName, String releaseNotes) throws GitLabApiException {
         Form formData = new GitLabApiForm().withParam("description", releaseNotes);
         Response response = post(Response.Status.CREATED, formData.asMap(),
-                "projects", getProjectIdOrPath(projectIdOrPath), "repository", "tags", tagName, "release");
+                "projects", getProjectIdOrPath(projectIdOrPath), "repository", "tags", urlEncode(tagName), "release");
         return (response.readEntity(Release.class));
     }
 
@@ -233,7 +233,8 @@ public Release createRelease(Object projectIdOrPath, String tagName, String rele
     public Release updateRelease(Object projectIdOrPath, String tagName, String releaseNotes) throws GitLabApiException {
         Form formData = new GitLabApiForm().withParam("description", releaseNotes);
         Response response = put(Response.Status.OK, formData.asMap(),
-                "projects", getProjectIdOrPath(projectIdOrPath), "repository", "tags", tagName, "release");
+                "projects", getProjectIdOrPath(projectIdOrPath), "repository", "tags", urlEncode(tagName), "release");
         return (response.readEntity(Release.class));
     }
+
 }

src/test/java/org/gitlab4j/api/TestTagsApi.java

@@ -23,6 +23,7 @@ public class TestTagsApi extends AbstractIntegrationTest {
 
     private static final String TEST_TAG_NAME_1 = "test-tag-1";
     private static final String TEST_TAG_NAME_0 = "test-tag-0";
+    private static final String TEST_TAG_WITH_SLASH = "env/test-tag";
 
     private static GitLabApi gitLabApi;
     private static Project testProject;
@@ -46,6 +47,10 @@ public static void testSetup() {
             try {
                 gitLabApi.getTagsApi().deleteTag(testProject, TEST_TAG_NAME_1);
             } catch (Exception ignore) {}
+
+            try {
+                gitLabApi.getTagsApi().deleteTag(testProject, TEST_TAG_WITH_SLASH);
+            } catch (Exception ignore) {}
         }
     }
 
@@ -59,6 +64,10 @@ public static void tearDown() {
             try {
                 gitLabApi.getTagsApi().deleteTag(testProject, TEST_TAG_NAME_1);
             } catch (Exception ignore) {}
+
+            try {
+                gitLabApi.getTagsApi().deleteTag(testProject, TEST_TAG_WITH_SLASH);
+            } catch (Exception ignore) {}
         }
     }
 
@@ -127,4 +136,15 @@ public void testGetTagsPager() throws GitLabApiException {
         assertTrue(tags.getTotalItems() > 0);
         assertTrue(tags.stream().map(Tag::getName).anyMatch(s -> TEST_TAG_NAME_0.equals(s)));
     }
+
+    @Test
+    public void testGetTagWithSpecialCharacersInTagName() throws GitLabApiException {
+        Tag testTag = gitLabApi.getTagsApi().createTag(testProject, TEST_TAG_WITH_SLASH, "master");
+        assertNotNull(testTag);
+        assertEquals(TEST_TAG_WITH_SLASH, testTag.getName());
+
+        testTag = gitLabApi.getTagsApi().getTag(testProject, TEST_TAG_WITH_SLASH);
+        assertNotNull(testTag);
+        assertEquals(TEST_TAG_WITH_SLASH, testTag.getName());
+    }
 }