diff --git a/src/components/Sidebar.test.tsx b/src/components/Sidebar.test.tsx index b9e5a82cd..685b496b3 100644 --- a/src/components/Sidebar.test.tsx +++ b/src/components/Sidebar.test.tsx @@ -137,7 +137,7 @@ describe('components/Sidebar.tsx', () => { describe('should render the notifications icon', () => { it('when there are 0 notifications', () => { - const { getByLabelText } = render( + const { getByTitle } = render( @@ -145,14 +145,14 @@ describe('components/Sidebar.tsx', () => { , ); - const notificationsIcon = getByLabelText('0 Unread Notifications'); + const notificationsIcon = getByTitle('0 Unread Notifications'); expect(notificationsIcon.className).toContain('text-white'); expect(notificationsIcon.childNodes.length).toBe(1); expect(notificationsIcon.childNodes[0].nodeName).toBe('svg'); }); it('when there are more than 0 notifications', () => { - const { getByLabelText } = render( + const { getByTitle } = render( { , ); - const notificationsIcon = getByLabelText('4 Unread Notifications'); + const notificationsIcon = getByTitle('4 Unread Notifications'); expect(notificationsIcon.className).toContain('text-green-500'); expect(notificationsIcon.childNodes.length).toBe(2); expect(notificationsIcon.childNodes[0].nodeName).toBe('svg'); diff --git a/src/components/Sidebar.tsx b/src/components/Sidebar.tsx index c0f685efa..8e56231af 100644 --- a/src/components/Sidebar.tsx +++ b/src/components/Sidebar.tsx @@ -52,16 +52,19 @@ export const Sidebar: React.FC = () => { -
0 ? 'text-green-500' : 'text-white' }`} onClick={onOpenGitHubNotifications} - aria-label={`${notificationsCount} Unread Notifications`} + title={`${notificationsCount} Unread Notifications`} > - + {notificationsCount > 0 && notificationsCount} -
+
diff --git a/src/components/__snapshots__/Sidebar.test.tsx.snap b/src/components/__snapshots__/Sidebar.test.tsx.snap index 5b1f0bf97..8db67adcc 100644 --- a/src/components/__snapshots__/Sidebar.test.tsx.snap +++ b/src/components/__snapshots__/Sidebar.test.tsx.snap @@ -59,13 +59,14 @@ exports[`components/Sidebar.tsx should render itself & its children (logged in) -
4 -
+
-
4 -
+