From bd13e3c20805a6c6b8a908334251a05c46a98829 Mon Sep 17 00:00:00 2001 From: Emmanouil Konstantinidis Date: Fri, 11 Dec 2020 22:27:05 +0000 Subject: [PATCH 1/3] feat: Hide app's dock icon --- main.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/main.js b/main.js index 5002f9918..2282aa818 100644 --- a/main.js +++ b/main.js @@ -17,6 +17,7 @@ const browserWindowOpts = { enableRemoteModule: true, overlayScrollbars: true, nodeIntegration: true, + contextIsolation: false, }, }; @@ -64,3 +65,7 @@ menubarApp.on('ready', () => { menubarApp.window.resizable = false; }); }); + +menubarApp.on('after-create-window', () => { + app.dock.hide(); +}); From edf443b2a76a32bff6b9ab1512cc4cfc8787562b Mon Sep 17 00:00:00 2001 From: Emmanouil Konstantinidis Date: Fri, 11 Dec 2020 22:28:55 +0000 Subject: [PATCH 2/3] chore: Apply prettier --- first-run.js | 3 +-- main.js | 9 +++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/first-run.js b/first-run.js index 249171211..00e32dc65 100644 --- a/first-run.js +++ b/first-run.js @@ -50,5 +50,4 @@ function isFirstRun() { return true; } -module.exports = { onFirstRunMaybe } - +module.exports = { onFirstRunMaybe }; diff --git a/main.js b/main.js index 2282aa818..ee38e565e 100644 --- a/main.js +++ b/main.js @@ -4,7 +4,12 @@ const { autoUpdater } = require('electron-updater'); const { onFirstRunMaybe } = require('./first-run'); const path = require('path'); -const iconIdle = path.join(__dirname, 'assets', 'images', 'tray-idleTemplate.png'); +const iconIdle = path.join( + __dirname, + 'assets', + 'images', + 'tray-idleTemplate.png' +); const iconActive = path.join(__dirname, 'assets', 'images', 'tray-active.png'); const browserWindowOpts = { @@ -23,7 +28,7 @@ const browserWindowOpts = { app.on('ready', async () => { await onFirstRunMaybe(); -}) +}); const menubarApp = menubar({ icon: iconIdle, From 7f1b33d1a9d9d0a0701957b25cb8cab0e4630889 Mon Sep 17 00:00:00 2001 From: Emmanouil Konstantinidis Date: Fri, 11 Dec 2020 22:47:47 +0000 Subject: [PATCH 3/3] chore: Delay calling app.dock.hide --- main.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/main.js b/main.js index ee38e565e..f6ad081f1 100644 --- a/main.js +++ b/main.js @@ -26,6 +26,13 @@ const browserWindowOpts = { }, }; +const delayedHideAppIcon = () => + // Setting a timeout because the showDockIcon is not currently working + // See more at https://github.com/maxogden/menubar/issues/306 + setTimeout(() => { + app.dock.hide(); + }, 1500); + app.on('ready', async () => { await onFirstRunMaybe(); }); @@ -38,6 +45,8 @@ const menubarApp = menubar({ }); menubarApp.on('ready', () => { + delayedHideAppIcon(); + menubarApp.tray.setIgnoreDoubleClickEvents(true); autoUpdater.checkForUpdatesAndNotify(); @@ -70,7 +79,3 @@ menubarApp.on('ready', () => { menubarApp.window.resizable = false; }); }); - -menubarApp.on('after-create-window', () => { - app.dock.hide(); -});