From 58be9c457b72c03ba2f290214fbb282a5ab87c30 Mon Sep 17 00:00:00 2001
From: Adam Setch <adam.setch@outlook.com>
Date: Wed, 25 Sep 2024 12:05:07 -0400
Subject: [PATCH] test: login with github

Signed-off-by: Adam Setch <adam.setch@outlook.com>
---
 src/routes/Accounts.test.tsx                  | 15 +++++++-------
 src/routes/Accounts.tsx                       |  2 +-
 src/routes/Login.test.tsx                     | 20 +++++++++++++++++++
 .../__snapshots__/Accounts.test.tsx.snap      |  2 +-
 4 files changed, 29 insertions(+), 10 deletions(-)

diff --git a/src/routes/Accounts.test.tsx b/src/routes/Accounts.test.tsx
index 768c7f25f..0c3ee7e5f 100644
--- a/src/routes/Accounts.test.tsx
+++ b/src/routes/Accounts.test.tsx
@@ -239,12 +239,15 @@ describe('routes/Accounts.tsx', () => {
 
   describe('Add new accounts', () => {
     it('should show login with github app', async () => {
+      const mockLoginWithGitHubApp = jest.fn();
+
       await act(async () => {
         render(
           <AppContext.Provider
             value={{
               auth: { accounts: [mockOAuthAccount] },
               settings: mockSettings,
+              loginWithGitHubApp: mockLoginWithGitHubApp,
             }}
           >
             <MemoryRouter>
@@ -254,9 +257,9 @@ describe('routes/Accounts.tsx', () => {
         );
       });
 
-      expect(screen.getByTitle('Login with GitHub App').hidden).toBe(false);
+      fireEvent.click(screen.getByTitle('Login with GitHub'));
 
-      fireEvent.click(screen.getByTitle('Login with GitHub App'));
+      expect(mockLoginWithGitHubApp).toHaveBeenCalled();
     });
 
     it('should show login with personal access token', async () => {
@@ -275,11 +278,8 @@ describe('routes/Accounts.tsx', () => {
         );
       });
 
-      expect(screen.getByTitle('Login with Personal Access Token').hidden).toBe(
-        false,
-      );
-
       fireEvent.click(screen.getByTitle('Login with Personal Access Token'));
+
       expect(mockNavigate).toHaveBeenNthCalledWith(
         1,
         '/login-personal-access-token',
@@ -305,9 +305,8 @@ describe('routes/Accounts.tsx', () => {
         );
       });
 
-      expect(screen.getByTitle('Login with OAuth App').hidden).toBe(false);
-
       fireEvent.click(screen.getByTitle('Login with OAuth App'));
+
       expect(mockNavigate).toHaveBeenNthCalledWith(1, '/login-oauth-app', {
         replace: true,
       });
diff --git a/src/routes/Accounts.tsx b/src/routes/Accounts.tsx
index ae8ffc8b8..e906ce1a9 100644
--- a/src/routes/Accounts.tsx
+++ b/src/routes/Accounts.tsx
@@ -186,7 +186,7 @@ export const AccountsRoute: FC = () => {
           <button
             type="button"
             className={BUTTON_CLASS_NAME}
-            title="Login with GitHub App"
+            title="Login with GitHub"
             onClick={loginWithGitHub}
           >
             <MarkGithubIcon
diff --git a/src/routes/Login.test.tsx b/src/routes/Login.test.tsx
index 64e440a96..fe14e6705 100644
--- a/src/routes/Login.test.tsx
+++ b/src/routes/Login.test.tsx
@@ -48,6 +48,26 @@ describe('routes/Login.tsx', () => {
     expect(mockNavigate).toHaveBeenNthCalledWith(1, '/', { replace: true });
   });
 
+  it('should login with github', () => {
+    const mockLoginWithGitHubApp = jest.fn();
+    render(
+      <AppContext.Provider
+        value={{
+          loginWithGitHubApp: mockLoginWithGitHubApp,
+        }}
+      >
+        <MemoryRouter>
+          <LoginRoute />
+        </MemoryRouter>
+        ,
+      </AppContext.Provider>,
+    );
+
+    fireEvent.click(screen.getByLabelText('Login with GitHub'));
+
+    expect(mockLoginWithGitHubApp).toHaveBeenCalled();
+  });
+
   it('should navigate to login with personal access token', () => {
     render(
       <MemoryRouter>
diff --git a/src/routes/__snapshots__/Accounts.test.tsx.snap b/src/routes/__snapshots__/Accounts.test.tsx.snap
index 4da1a9b83..2908cc39f 100644
--- a/src/routes/__snapshots__/Accounts.test.tsx.snap
+++ b/src/routes/__snapshots__/Accounts.test.tsx.snap
@@ -592,7 +592,7 @@ exports[`routes/Accounts.tsx General should render itself & its children 1`] = `
     <div>
       <button
         class="hover:text-gray-500 py-1 px-2 my-1 mx-2 focus:outline-none"
-        title="Login with GitHub App"
+        title="Login with GitHub"
         type="button"
       >
         <svg