diff --git a/biome.json b/biome.json index 8b73637ee..bac4f37fb 100644 --- a/biome.json +++ b/biome.json @@ -11,6 +11,9 @@ "noUnusedFunctionParameters": "error", "useDefaultSwitchClause": "error" }, + "a11y": { + "useKeyWithClickEvents": "off" + }, "correctness": { "useExhaustiveDependencies": { "level": "warn", diff --git a/src/components/AccountNotifications.tsx b/src/components/AccountNotifications.tsx index d97b98555..15dbe2232 100644 --- a/src/components/AccountNotifications.tsx +++ b/src/components/AccountNotifications.tsx @@ -55,8 +55,11 @@ export const AccountNotifications = (props: IProps) => { return ( <> {showAccountHostname && ( -
-
+
+
diff --git a/src/components/NotificationRow.test.tsx b/src/components/NotificationRow.test.tsx index 567b7080b..29f28aeba 100644 --- a/src/components/NotificationRow.test.tsx +++ b/src/components/NotificationRow.test.tsx @@ -399,7 +399,7 @@ describe('components/NotificationRow.tsx', () => { , ); - fireEvent.keyDown(screen.getByRole('main')); + fireEvent.click(screen.getByRole('main')); expect(links.openNotification).toHaveBeenCalledTimes(1); expect(removeNotificationFromState).toHaveBeenCalledTimes(1); }); diff --git a/src/components/NotificationRow.tsx b/src/components/NotificationRow.tsx index 6a6bb4d4c..bcd9ff4e5 100644 --- a/src/components/NotificationRow.tsx +++ b/src/components/NotificationRow.tsx @@ -118,7 +118,6 @@ export const NotificationRow: FC = ({ notification }) => {
handleNotification()} - onKeyDown={() => handleNotification()} >
= ({ notification }) => { - - + +
); diff --git a/src/components/Repository.tsx b/src/components/Repository.tsx index 26da6b267..a0cc564f3 100644 --- a/src/components/Repository.tsx +++ b/src/components/Repository.tsx @@ -51,7 +51,10 @@ export const RepositoryNotifications: FC = ({ return ( <> -
+
{avatarUrl ? ( = ({ openRepository(repoNotifications[0].repository)} - onKeyDown={() => openRepository(repoNotifications[0].repository)} > {repoName}
- -
- + +
diff --git a/src/components/__snapshots__/AccountNotifications.test.tsx.snap b/src/components/__snapshots__/AccountNotifications.test.tsx.snap index 4c8abbbfd..4ddee861d 100644 --- a/src/components/__snapshots__/AccountNotifications.test.tsx.snap +++ b/src/components/__snapshots__/AccountNotifications.test.tsx.snap @@ -8,7 +8,9 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
-
+
@@ -71,7 +73,9 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
-
+
@@ -191,7 +195,9 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
-
+
-
+
-
+
@@ -427,7 +437,9 @@ exports[`components/AccountNotifications.tsx should toggle account notifications
-
+
@@ -490,7 +502,9 @@ exports[`components/AccountNotifications.tsx should toggle account notifications
-
+
diff --git a/src/components/__snapshots__/NotificationRow.test.tsx.snap b/src/components/__snapshots__/NotificationRow.test.tsx.snap index 962b45f3d..1ade8bac3 100644 --- a/src/components/__snapshots__/NotificationRow.test.tsx.snap +++ b/src/components/__snapshots__/NotificationRow.test.tsx.snap @@ -193,13 +193,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics comment pil @@ -427,13 +427,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics comment pil @@ -718,13 +718,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics comment pil @@ -952,13 +952,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics comment pil @@ -1221,13 +1221,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics comment pil @@ -1433,13 +1433,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics comment pil @@ -1748,13 +1748,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics label pills @@ -2006,13 +2006,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics label pills @@ -2275,13 +2275,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics linked issu @@ -2487,13 +2487,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics linked issu @@ -2756,13 +2756,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics linked issu @@ -2968,13 +2968,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics linked issu @@ -3304,13 +3304,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics milestone p @@ -3583,13 +3583,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics milestone p @@ -3919,13 +3919,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics milestone p @@ -4198,13 +4198,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics milestone p @@ -4394,13 +4394,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics showPills d @@ -4533,13 +4533,13 @@ exports[`components/NotificationRow.tsx notification pills / metrics showPills d @@ -4773,13 +4773,13 @@ exports[`components/NotificationRow.tsx should render itself & its children 1`] @@ -4956,13 +4956,13 @@ exports[`components/NotificationRow.tsx should render itself & its children 1`] @@ -5196,13 +5196,13 @@ exports[`components/NotificationRow.tsx should render itself & its children when @@ -5379,13 +5379,13 @@ exports[`components/NotificationRow.tsx should render itself & its children when @@ -5623,13 +5623,13 @@ exports[`components/NotificationRow.tsx should render itself & its children with @@ -5810,13 +5810,13 @@ exports[`components/NotificationRow.tsx should render itself & its children with diff --git a/src/components/__snapshots__/Repository.test.tsx.snap b/src/components/__snapshots__/Repository.test.tsx.snap index 47ecbbd76..729d3066f 100644 --- a/src/components/__snapshots__/Repository.test.tsx.snap +++ b/src/components/__snapshots__/Repository.test.tsx.snap @@ -27,66 +27,63 @@ exports[`components/Repository.tsx should render itself & its children 1`] = ` > -
@@ -123,66 +120,63 @@ exports[`components/Repository.tsx should render itself & its children 1`] = ` > -
@@ -285,66 +279,63 @@ exports[`components/Repository.tsx should toggle account notifications visibilit > -
@@ -383,66 +374,63 @@ exports[`components/Repository.tsx should toggle account notifications visibilit > -
@@ -488,66 +476,63 @@ exports[`components/Repository.tsx should toggle account notifications visibilit > -
@@ -650,66 +635,63 @@ exports[`components/Repository.tsx should use default repository icon when avata > -
@@ -755,66 +737,63 @@ exports[`components/Repository.tsx should use default repository icon when avata > -