Skip to content

Commit beb84a0

Browse files
authored
test: remove unused memoryrouter (#2212)
Signed-off-by: Adam Setch <[email protected]>
1 parent 40fbdc1 commit beb84a0

21 files changed

+125
-343
lines changed

src/renderer/components/AllRead.test.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { act, render } from '@testing-library/react';
2-
import { MemoryRouter } from 'react-router-dom';
32

43
import { mockSettings } from '../__mocks__/state-mocks';
54
import { ensureStableEmojis } from '../__mocks__/utils';
@@ -44,9 +43,7 @@ describe('renderer/components/AllRead.tsx', () => {
4443
},
4544
}}
4645
>
47-
<MemoryRouter>
48-
<AllRead />
49-
</MemoryRouter>
46+
<AllRead />
5047
</AppContext.Provider>,
5148
);
5249
});

src/renderer/components/filters/FilterSection.test.tsx

Lines changed: 24 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { act, render, screen } from '@testing-library/react';
22
import userEvent from '@testing-library/user-event';
3-
import { MemoryRouter } from 'react-router-dom';
43

54
import { MarkGithubIcon } from '@primer/octicons-react';
65

@@ -29,18 +28,16 @@ describe('renderer/components/filters/FilterSection.tsx', () => {
2928
notifications: mockAccountNotifications,
3029
}}
3130
>
32-
<MemoryRouter>
33-
<FilterSection
34-
filter={{
35-
...mockFilter,
36-
requiresDetailsNotifications: true,
37-
}}
38-
filterSetting={mockFilterSetting}
39-
icon={MarkGithubIcon}
40-
id={'FilterSectionTest'}
41-
title={'FilterSectionTitle'}
42-
/>
43-
</MemoryRouter>
31+
<FilterSection
32+
filter={{
33+
...mockFilter,
34+
requiresDetailsNotifications: true,
35+
}}
36+
filterSetting={mockFilterSetting}
37+
icon={MarkGithubIcon}
38+
id={'FilterSectionTest'}
39+
title={'FilterSectionTitle'}
40+
/>
4441
</AppContext.Provider>,
4542
);
4643

@@ -88,15 +85,13 @@ describe('renderer/components/filters/FilterSection.tsx', () => {
8885
updateFilter,
8986
}}
9087
>
91-
<MemoryRouter>
92-
<FilterSection
93-
filter={mockFilter}
94-
filterSetting={mockFilterSetting}
95-
icon={MarkGithubIcon}
96-
id={'FilterSectionTest'}
97-
title={'FilterSectionTitle'}
98-
/>
99-
</MemoryRouter>
88+
<FilterSection
89+
filter={mockFilter}
90+
filterSetting={mockFilterSetting}
91+
icon={MarkGithubIcon}
92+
id={'FilterSectionTest'}
93+
title={'FilterSectionTitle'}
94+
/>
10095
</AppContext.Provider>,
10196
);
10297
});
@@ -123,15 +118,13 @@ describe('renderer/components/filters/FilterSection.tsx', () => {
123118
updateFilter,
124119
}}
125120
>
126-
<MemoryRouter>
127-
<FilterSection
128-
filter={mockFilter}
129-
filterSetting={mockFilterSetting}
130-
icon={MarkGithubIcon}
131-
id={'FilterSectionTest'}
132-
title={'FilterSectionTitle'}
133-
/>
134-
</MemoryRouter>
121+
<FilterSection
122+
filter={mockFilter}
123+
filterSetting={mockFilterSetting}
124+
icon={MarkGithubIcon}
125+
id={'FilterSectionTest'}
126+
title={'FilterSectionTitle'}
127+
/>
135128
</AppContext.Provider>,
136129
);
137130
});

src/renderer/components/filters/ReasonFilter.test.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { render } from '@testing-library/react';
2-
import { MemoryRouter } from 'react-router-dom';
32

43
import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
54
import { mockSettings } from '../../__mocks__/state-mocks';
@@ -15,9 +14,7 @@ describe('renderer/components/filters/ReasonFilter.tsx', () => {
1514
notifications: mockAccountNotifications,
1615
}}
1716
>
18-
<MemoryRouter>
19-
<ReasonFilter />
20-
</MemoryRouter>
17+
<ReasonFilter />
2118
</AppContext.Provider>,
2219
);
2320

src/renderer/components/filters/RequiresDetailedNotificationsWarning.test.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { render } from '@testing-library/react';
2-
import { MemoryRouter } from 'react-router-dom';
32

43
import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
54
import { mockSettings } from '../../__mocks__/state-mocks';
@@ -15,9 +14,7 @@ describe('renderer/components/filters/RequiresDetailedNotificationsWarning.tsx',
1514
notifications: mockAccountNotifications,
1615
}}
1716
>
18-
<MemoryRouter>
19-
<RequiresDetailedNotificationWarning />
20-
</MemoryRouter>
17+
<RequiresDetailedNotificationWarning />
2118
</AppContext.Provider>,
2219
);
2320

src/renderer/components/filters/StateFilter.test.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { render } from '@testing-library/react';
2-
import { MemoryRouter } from 'react-router-dom';
32

43
import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
54
import { mockSettings } from '../../__mocks__/state-mocks';
@@ -19,9 +18,7 @@ describe('renderer/components/filters/StateFilter.tsx', () => {
1918
notifications: mockAccountNotifications,
2019
}}
2120
>
22-
<MemoryRouter>
23-
<StateFilter />
24-
</MemoryRouter>
21+
<StateFilter />
2522
</AppContext.Provider>,
2623
);
2724

src/renderer/components/filters/SubjectTypeFilter.test.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { render } from '@testing-library/react';
2-
import { MemoryRouter } from 'react-router-dom';
32

43
import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
54
import { mockSettings } from '../../__mocks__/state-mocks';
@@ -18,9 +17,7 @@ describe('renderer/components/filters/SubjectTypeFilter.tsx', () => {
1817
notifications: mockAccountNotifications,
1918
}}
2019
>
21-
<MemoryRouter>
22-
<SubjectTypeFilter />
23-
</MemoryRouter>
20+
<SubjectTypeFilter />
2421
</AppContext.Provider>,
2522
);
2623

src/renderer/components/filters/UserHandleFilter.test.tsx

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { act, render, screen } from '@testing-library/react';
22
import userEvent from '@testing-library/user-event';
3-
import { MemoryRouter } from 'react-router-dom';
43

54
import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
65
import { mockSettings } from '../../__mocks__/state-mocks';
@@ -27,9 +26,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
2726
notifications: mockAccountNotifications,
2827
}}
2928
>
30-
<MemoryRouter>
31-
<UserHandleFilter />
32-
</MemoryRouter>
29+
<UserHandleFilter />
3330
</AppContext.Provider>,
3431
);
3532

@@ -47,9 +44,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
4744
notifications: mockAccountNotifications,
4845
}}
4946
>
50-
<MemoryRouter>
51-
<UserHandleFilter />
52-
</MemoryRouter>
47+
<UserHandleFilter />
5348
</AppContext.Provider>,
5449
);
5550

@@ -71,9 +66,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
7166
updateFilter,
7267
}}
7368
>
74-
<MemoryRouter>
75-
<UserHandleFilter />
76-
</MemoryRouter>
69+
<UserHandleFilter />
7770
</AppContext.Provider>,
7871
);
7972
});
@@ -103,9 +96,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
10396
updateFilter,
10497
}}
10598
>
106-
<MemoryRouter>
107-
<UserHandleFilter />
108-
</MemoryRouter>
99+
<UserHandleFilter />
109100
</AppContext.Provider>,
110101
);
111102
});
@@ -133,9 +124,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
133124
updateFilter,
134125
}}
135126
>
136-
<MemoryRouter>
137-
<UserHandleFilter />
138-
</MemoryRouter>
127+
<UserHandleFilter />
139128
</AppContext.Provider>,
140129
);
141130
});
@@ -165,9 +154,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
165154
updateFilter,
166155
}}
167156
>
168-
<MemoryRouter>
169-
<UserHandleFilter />
170-
</MemoryRouter>
157+
<UserHandleFilter />
171158
</AppContext.Provider>,
172159
);
173160
});

src/renderer/components/filters/UserTypeFilter.test.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { render } from '@testing-library/react';
2-
import { MemoryRouter } from 'react-router-dom';
32

43
import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
54
import { mockSettings } from '../../__mocks__/state-mocks';
@@ -19,9 +18,7 @@ describe('renderer/components/filters/UserTypeFilter.tsx', () => {
1918
notifications: mockAccountNotifications,
2019
}}
2120
>
22-
<MemoryRouter>
23-
<UserTypeFilter />
24-
</MemoryRouter>
21+
<UserTypeFilter />
2522
</AppContext.Provider>,
2623
);
2724

src/renderer/components/settings/AppearanceSettings.test.tsx

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { act, fireEvent, render, screen } from '@testing-library/react';
22
import userEvent from '@testing-library/user-event';
3-
import { MemoryRouter } from 'react-router-dom';
43

54
import {
65
mockAuth,
@@ -28,9 +27,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
2827
updateSetting,
2928
}}
3029
>
31-
<MemoryRouter>
32-
<AppearanceSettings />
33-
</MemoryRouter>
30+
<AppearanceSettings />
3431
</AppContext.Provider>,
3532
);
3633
});
@@ -56,9 +53,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
5653
updateSetting,
5754
}}
5855
>
59-
<MemoryRouter>
60-
<AppearanceSettings />
61-
</MemoryRouter>
56+
<AppearanceSettings />
6257
</AppContext.Provider>,
6358
);
6459
});
@@ -81,9 +76,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
8176
updateSetting,
8277
}}
8378
>
84-
<MemoryRouter>
85-
<AppearanceSettings />
86-
</MemoryRouter>
79+
<AppearanceSettings />
8780
</AppContext.Provider>,
8881
);
8982
});
@@ -111,9 +104,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
111104
updateSetting,
112105
}}
113106
>
114-
<MemoryRouter>
115-
<AppearanceSettings />
116-
</MemoryRouter>
107+
<AppearanceSettings />
117108
</AppContext.Provider>,
118109
);
119110
});
@@ -166,9 +157,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
166157
updateSetting,
167158
}}
168159
>
169-
<MemoryRouter>
170-
<AppearanceSettings />
171-
</MemoryRouter>
160+
<AppearanceSettings />
172161
</AppContext.Provider>,
173162
);
174163
});
@@ -191,9 +180,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
191180
updateSetting,
192181
}}
193182
>
194-
<MemoryRouter>
195-
<AppearanceSettings />
196-
</MemoryRouter>
183+
<AppearanceSettings />
197184
</AppContext.Provider>,
198185
);
199186
});

0 commit comments

Comments
 (0)