refactor: use URL to build href (#1309)

Author: setchy

src/utils/auth/utils.test.ts

@@ -47,7 +47,7 @@ describe('utils/auth/utils.ts', () => {
 
       expect(loadURLMock).toHaveBeenCalledTimes(1);
       expect(loadURLMock).toHaveBeenCalledWith(
-        'https://github.com/login/oauth/authorize?client_id=FAKE_CLIENT_ID_123&scope=read:user,notifications,repo',
+        'https://github.com/login/oauth/authorize?client_id=FAKE_CLIENT_ID_123&scope=read%3Auser%2Cnotifications%2Crepo',
       );
 
       expect(browserWindow.destroy).toHaveBeenCalledTimes(1);

src/utils/auth/utils.ts

@@ -28,13 +28,15 @@ export function authGitHub(
       show: true,
     });
 
-    const githubUrl = `https://${authOptions.hostname}/login/oauth/authorize`;
-    const authUrl = `${githubUrl}?client_id=${authOptions.clientId}&scope=${Constants.AUTH_SCOPE}`;
+    const authUrl = new URL(`https://${authOptions.hostname}`);
+    authUrl.pathname = '/login/oauth/authorize';
+    authUrl.searchParams.append('client_id', authOptions.clientId);
+    authUrl.searchParams.append('scope', Constants.AUTH_SCOPE.toString());
 
     const session = authWindow.webContents.session;
     session.clearStorageData();
 
-    authWindow.loadURL(authUrl);
+    authWindow.loadURL(authUrl.toString());
 
     const handleCallback = (url: Link) => {
       const raw_code = /code=([^&]*)/.exec(url) || null;