fix issues noted in rubocop test run

Author: Isaiah Frantz

lib/octocatalog-diff/util/parallel.rb

@@ -129,7 +129,7 @@ def self.run_tasks_parallel(result, task_array, logger)
 
         # Waiting for children and handling results
         while pidmap.any?
-          pidmap.each do |pid, stuff|
+          pidmap.each do |pid|
             status = Process.waitpid2(pid, Process::WNOHANG)
             next if status.nil?
             this_pid, exit_obj = status

spec/octocatalog-diff/tests/util/parallel_spec.rb

@@ -39,7 +39,7 @@ def wait_on_me(pid)
           status = nil
           # just in case status never equals anything
           count = 100 
-          while status.nil? or count > 0
+          while status.nil? || count > 0
             count -= 1
             status = Process.waitpid2(pid, Process::WNOHANG)
           end
@@ -49,7 +49,7 @@ def wait_on_me(pid)
 
       c = Foo.new
       # start my non-parallel process first
-      just_a_guy = c.dont_wait_me_bro()
+      just_a_guy = c.dont_wait_me_bro
 
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1')
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2')
@@ -539,4 +539,4 @@ def validate(arg, _logger = nil, _extra_args = {})
       end.to raise_error(ArgumentError, /Element .* must be a OctocatalogDiff::Util::Parallel::Task, not a /)
     end
   end
-end
+end