Merge pull request #267 from cjmartian/update-rake

Update rake to 12.3.3

Author: cjmartian

Gemfile

@@ -1,3 +1,6 @@
 source 'https://rubygems.org'
 
+gem 'rake', '12.3.3'
+gem 'httparty', '0.16.3'
+
 gemspec

spec/octocatalog-diff/fixtures/git-repos/simple-repo.tgz

@@ -7,6 +7,7 @@
 require 'json'
 require 'open3'
 require 'rugged'
+require 'tmpdir'
 
 describe OctocatalogDiff::CatalogUtil::CachedMasterDirectory do
   before(:all) do

spec/octocatalog-diff/tests/catalog-util/cached_master_directory_spec.rb

@@ -2,7 +2,9 @@
 require 'logger'
 require 'rspec'
 require 'rspec/retry'
+require 'rubygems/package'
 require 'tempfile'
+require 'tmpdir'
 
 # Enable SimpleCov coverage testing?
 if ENV['COVERAGE']
@@ -209,23 +211,22 @@ def self.test_command(command)
     # Check out fixture repo. The repository is a tarball; this extracts it to a temporary directory and returns
     # the path where it was checked out. If the checkout fails, returns nil. Note: Be sure to include code in the
     # caller to clean up the temporary directory upon exit.
-    # @param repo [String] Name of repository (in fixtures/git-repos/{repo}.tar)
+    # @param repo [String] Name of repository (in fixtures/git-repos/{repo}.tgz)
     # @return [String] Path to checkout
     def self.extract_fixture_repo(repo)
       # If tar isn't here, don't do this
       has_tar = test_command('tar --version')
       return nil unless has_tar.nil?
 
       # Make sure tarball is there
-      repo_tarball = fixture_path("git-repos/#{repo}.tar")
+      repo_tarball = fixture_path("git-repos/#{repo}.tgz")
       raise Errno::ENOENT, "Repo tarball for #{repo} not found in #{repo_tarball}" unless File.file?(repo_tarball)
 
       # Extract to temporary directory
       extract_dir = Dir.mktmpdir
-      cmd = "tar -xf #{Shellwords.escape(repo_tarball)}"
-      extract_result, extract_code = Open3.capture2e(cmd, chdir: extract_dir)
-      return extract_dir if extract_code.exitstatus.zero?
-      raise "Failed to extract #{repo_tarball}: #{extract_result} (#{extract_code.exitstatus})"
+      io = File.open(repo_tarball, 'rb')
+      Gem::Package.new("").extract_tar_gz(io, extract_dir)
+      return extract_dir
     end
 
     # Clean up a temporary directory. This does nothing if the directory doesn't exist, or if it's nil.