all tests pass

Author: khiga8

lib/rules/a11y-no-generic-link-text.js

@@ -1,5 +1,5 @@
 const {getProp, getPropValue} = require('jsx-ast-utils')
-const {getElementType} = require('../utils/get-element-type.js')
+const {getElementType} = require('../utils/get-element-type')
 
 const bannedLinkText = ['read more', 'here', 'click here', 'learn more', 'more', 'here']
 

lib/utils/get-element-type.js

@@ -15,8 +15,8 @@ function getElementType(context, node) {
     const props = Object.entries(component.props)
     for (const [key, value] of props) {
       const propMap = value
-      let propValue = getPropValue(getProp(node.attributes, key))
-      let mapValue = propMap[propValue]
+      const propValue = getPropValue(getProp(node.attributes, key))
+      const mapValue = propMap[propValue]
 
       if (mapValue) {
         element = mapValue

package.json

@@ -12,7 +12,7 @@
   "scripts": {
     "pretest": "mkdir -p node_modules/ && ln -fs $(pwd) node_modules/",
     "eslint-check": "eslint-config-prettier .eslintrc.js",
-    "test": "mocha ./tests/**/*.js ./tests/*.js"
+    "test": "npm run eslint-check && eslint . && mocha tests/**/*.js tests/"
   },
   "repository": {
     "type": "git",
@@ -51,7 +51,6 @@
   ],
   "devDependencies": {
     "@github/prettier-config": "0.0.4",
-    "chai": "^4.3.6",
     "eslint": "^8.0.1",
     "eslint-plugin-eslint-plugin": "^5.0.0",
     "mocha": "^10.0.0"

tests/a11y-no-generic-link-text.js

@@ -27,16 +27,17 @@ ruleTester.run('a11y-no-generic-link-text', rule, {
         github: {
           components: {
             Link: {
-              props: { as: {undefined: 'a'} }
+              props: {as: {undefined: 'a'}}
             }
           }
         }
       }
-    },
+    }
   ],
   invalid: [
     {
       code: '<ButtonLink href="#">Read more</ButtonLink>',
+      errors: [{message: errorMessage}],
       settings: {
         github: {
           components: {
@@ -45,34 +46,33 @@ ruleTester.run('a11y-no-generic-link-text', rule, {
             }
           }
         }
-      },
-      errors:  [{message: errorMessage}]
+      }
     },
     {
       code: '<Link href="#">Read more</Link>',
+      errors: [{message: errorMessage}],
       settings: {
         github: {
           components: {
             Link: {
-              props: { as: {undefined: 'a'} }
+              props: {as: {undefined: 'a'}}
             }
           }
         }
-      },
-      errors:  [{message: errorMessage}]
+      }
     },
     {
       code: '<Test as="a" href="#">Read more</Test>',
+      errors: [{message: errorMessage}],
       settings: {
         github: {
           components: {
             Test: {
-              props: { as: {'a': 'a'} }
+              props: {as: {a: 'a'}}
             }
           }
         }
-      },
-      errors:  [{message: errorMessage}]
+      }
     },
     {
       code: "<Box><a href='#'>Click here</a></Box>;",

tests/utils/get-element-type.js

@@ -1,4 +1,7 @@
 const {getElementType} = require('../../lib/utils/get-element-type')
+const mocha = require('mocha')
+const describe = mocha.describe
+const it = mocha.it
 const expect = require('chai').expect
 
 function mockJSXAttribute(prop, propValue) {
@@ -15,7 +18,7 @@ function mockJSXAttribute(prop, propValue) {
   }
 }
 
-function mockJSXOpeningElement(tagName, attributes = [], children = []) {
+function mockJSXOpeningElement(tagName, attributes = []) {
   return {
     type: 'JSXOpeningElement',
     name: {
@@ -37,12 +40,12 @@ function mockSetting(componentSetting = {}) {
 }
 
 describe('getElementType', function () {
-  it('gets element type', function () {
+  it('returns raw element type', function () {
     const node = mockJSXOpeningElement('a')
     expect(getElementType({}, node)).to.equal('a')
   })
 
-  it('gets element type from default', function () {
+  it('returns element type from default if set', function () {
     const node = mockJSXOpeningElement('Link', [mockJSXAttribute('as', 'summary')])
     const setting = mockSetting({
       Link: {
@@ -52,7 +55,7 @@ describe('getElementType', function () {
     expect(getElementType(setting, node)).to.equal('button')
   })
 
-  it('gets element type from matching props setting', function () {
+  it('returns element type from matching props setting if set', function () {
     const setting = mockSetting({
       Link: {
         default: 'a',
@@ -61,17 +64,12 @@ describe('getElementType', function () {
         }
       }
     })
-    const node_1 = mockJSXOpeningElement('Link')
-    expect(getElementType(setting, node_1)).to.equal('a')
 
-    const node_2 = mockJSXOpeningElement('Link', [mockJSXAttribute('as', 'p')])
-    expect(getElementType(setting, node_2)).to.equal('a')
-
-    const node_3 = mockJSXOpeningElement('Link', [mockJSXAttribute('as', 'summary')])
-    expect(getElementType(setting, node_3)).to.equal('summary')
+    const node = mockJSXOpeningElement('Link', [mockJSXAttribute('as', 'summary')])
+    expect(getElementType(setting, node)).to.equal('summary')
   })
 
-  it('uses original type if no default or matching prop setting', function () {
+  it('returns raw type if no default or matching prop setting', function () {
     const setting = mockSetting({
       Link: {
         props: {
@@ -95,7 +93,7 @@ describe('getElementType', function () {
     expect(getElementType(setting, node)).to.equal('a')
   })
 
-  it('falls back to original type if no default and prop does not match props setting', function () {
+  it('returns raw type if prop does not match props setting and no default type', function () {
     const setting = mockSetting({
       Link: {
         props: {