Add aria-label and aria-labelledby and alt and name

Add additional dis-ambiguating attributes.

When `aria-label` or `aria-labelledby` is set at all, constraints should be set.

Author: khiga8

lib/rules/role-supports-aria-props.js

@@ -9,10 +9,6 @@ const elementRolesMap = new ObjectMap()
 for (const [key, value] of elementRoles.entries()) {
   // - Remove unused `constraints` key
   delete key.constraints
-  // - Remove `constraints` key within `attributes`
-  for (const attribute of key.attributes || []) {
-    delete attribute.constraints
-  }
   // - Remove empty `attributes` key
   if (!key.attributes || key.attributes?.length === 0) {
     delete key.attributes
@@ -44,14 +40,31 @@ module.exports = {
         // - Get the element’s name
         const key = {name: getElementType(context, node)}
         // - Get the element’s disambiguating attributes
-        for (const prop of ['type', 'size', 'role', 'href', 'multiple', 'scope']) {
+        for (const prop of [
+          'aria-label',
+          'aria-labelledby',
+          'alt',
+          'type',
+          'size',
+          'role',
+          'href',
+          'multiple',
+          'scope',
+          'name',
+        ]) {
+          if ((prop === 'aria-labelledby' || prop === 'aria-label') && !['section', 'aside', 'form'].includes(key.name))
+            continue
+          if (prop === 'name' && key.name !== 'form') continue
+
           const value = getPropValue(getProp(node.attributes, prop))
           if (value) {
             if (!('attributes' in key)) {
               key.attributes = []
             }
-            if (prop === 'href') {
-              key.attributes.push({name: prop})
+            if (prop === 'href' || prop === 'aria-labelledby' || prop === 'aria-label') {
+              key.attributes.push({name: prop, constraints: ['set']})
+            } else if (prop === 'alt' && value !== '') {
+              key.attributes.push({name: prop, constraints: ['set']})
             } else {
               key.attributes.push({name: prop, value})
             }