C++: Rewrite cpp/unbounded-write away from DefaultTaintTracking
#14669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the
cpp/unbounded-writequery away fromDefaultTaintTracking. MRVA does report some result changes (both new results and disappearing results). The new results all look genuine, and were hidden by the bad default barriers inDefaultTaintTracking, and all of the disappearing results have been FPs being removed because we now realise that a variable is being overwritten along the path (which we didn't do before becauseDefaultTaintTrackingconflatedxandglval<x>).CI is unhappy because of internal test changes. I've accepted these in the internal repo.