Skip to content

Commit 8047450

Browse files
committed
javascript: Update property access for `document.defaultView as getAPropertyRead
Changed the method for accessing `defaultView` from `getAPropertyReference` to `getAPropertyRead` to improve accuracy in data flow analysis for global variable references.
1 parent bd18e86 commit 8047450

File tree

1 file changed

+1
-1
lines changed
  • javascript/ql/lib/semmle/javascript/dataflow

1 file changed

+1
-1
lines changed

javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ DataFlow::SourceNode globalObjectRef() {
384384
result = globalVariable("window")
385385
or
386386
// DOM alias via `document.defaultView`
387-
result = globalVariable("document").getAPropertyReference("defaultView")
387+
result = globalVariable("document").getAPropertyRead("defaultView")
388388
or
389389
// Node.js
390390
result = globalVariable("global")

0 commit comments

Comments
 (0)