Fix addSarifExtension and add tests

Author: mbg

lib/analyze-action.js

@@ -10,6 +10,7 @@ import {
   runQueries,
   defaultSuites,
   resolveQuerySuiteAlias,
+  addSarifExtension,
 } from "./analyze";
 import { createStubCodeQL } from "./codeql";
 import { Feature } from "./feature-flags";
@@ -23,6 +24,7 @@ import {
 } from "./testing-utils";
 import * as uploadLib from "./upload-lib";
 import * as util from "./util";
+import { CodeQuality, CodeScanning } from "./analyses";
 
 setupTests(test);
 
@@ -348,3 +350,13 @@ test("resolveQuerySuiteAlias", (t) => {
     t.deepEqual(resolveQuerySuiteAlias(KnownLanguage.go, name), name);
   }
 });
+
+test("addSarifExtension", (t) => {
+  for (const language of Object.values(KnownLanguage)) {
+    t.deepEqual(addSarifExtension(CodeScanning, language), `${language}.sarif`);
+    t.deepEqual(
+      addSarifExtension(CodeQuality, language),
+      `${language}.quality.sarif`,
+    );
+  }
+});

src/analyze.test.ts

@@ -615,7 +615,7 @@ export function addSarifExtension(
   analysis: analyses.AnalysisConfig,
   base: string,
 ): string {
-  return `${base}.${analysis.sarifExtension}`;
+  return `${base}${analysis.sarifExtension}`;
 }
 
 // Runs queries and creates sarif files in the given folder