From f5431921d8b0df185a070993781d3419f98f4de0 Mon Sep 17 00:00:00 2001 From: Steven Kirk Date: Fri, 13 Jul 2018 13:19:36 +0200 Subject: [PATCH] Unsubscribe when PR list view is unloaded. --- .../Views/GitHubPane/PullRequestListView.xaml.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListView.xaml.cs b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListView.xaml.cs index 39b44c4c45..6ddf3b4b70 100644 --- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListView.xaml.cs +++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListView.xaml.cs @@ -27,6 +27,7 @@ public partial class PullRequestListView : UserControl public PullRequestListView() { InitializeComponent(); + DataContextChanged += (s, e) => { var vm = DataContext as IPullRequestListViewModel; @@ -42,6 +43,12 @@ public PullRequestListView() vm.OpenItemInBrowser.Subscribe(x => OpenInBrowser((IPullRequestListItemViewModel)x))); } }; + + Unloaded += (s, e) => + { + subscription?.Dispose(); + subscription = null; + }; } [Import]